Re: [Spice-devel] [PATCH 2/3] improve performances comparing image pixels

2015-09-03 Thread Jonathon Jongsma
Out of curiosity, did you measure the performance impact of these changes? If so, it would be nice to include this in the commit log. Just a few minor terminology suggestions below On Fri, 2015-08-21 at 10:57 +0100, Frediano Ziglio wrote: > This patch contains a bit of small optimizations. > It

[Spice-devel] [PATCH 2/3] improve performances comparing image pixels

2015-08-21 Thread Frediano Ziglio
This patch contains a bit of small optimizations. It avoid booleans operations which could involve branches replacing with binary operations (equal/all_ident -> some_differences). The other optimization avoid the use of ABS. First the way the macro was used (with a large expression) was not easy to