Re: [Spice-devel] [PATCH 2/2] do not link spice with libcacard

2015-10-13 Thread Christophe Fergeau
On Fri, Oct 09, 2015 at 07:32:33PM +0300, Michael Tokarev wrote: > Well, not exactly. Why don't you keep the variables in the final > SPICE_COMMON_{CFLAGS,LIBS} line my first patch does, instead of > expanding the values at configure time? This way it will be possible > to override the components

Re: [Spice-devel] [PATCH 2/2] do not link spice with libcacard

2015-10-09 Thread Michael Tokarev
09.10.2015 16:36, Christophe Fergeau wrote: >> --- a/spice-common/m4/spice-deps.m4 >> +++ b/spice-common/m4/spice-deps.m4 >> @@ -58,7 +58,8 @@ AC_DEFUN([SPICE_CHECK_SMARTCARD], [ >>fi >> fi >> AS_VAR_APPEND([$1_CFLAGS], [' $(SMARTCARD_CFLAGS)']) >> -AS_VAR_APPEND([$1_LIBS], ['

Re: [Spice-devel] [PATCH 2/2] do not link spice with libcacard

2015-10-09 Thread Christophe Fergeau
Hi, Thanks for the 2 patches! On Fri, Oct 09, 2015 at 01:04:12AM +0300, Michael Tokarev wrote: > None of the libcacard symbols are actually used by the library, > only the header files, so there's no need to link with libcacard. > > Signed-off-by: Michael Tokarev > --- > spice-common/m4/spice-

[Spice-devel] [PATCH 2/2] do not link spice with libcacard

2015-10-08 Thread Michael Tokarev
None of the libcacard symbols are actually used by the library, only the header files, so there's no need to link with libcacard. Signed-off-by: Michael Tokarev --- spice-common/m4/spice-deps.m4 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/spice-common/m4/spice-deps.m4 b