Re: [Spice-devel] [PATCH 2/2] avoid integer underflow under 32 bit architectures

2016-06-05 Thread Fabiano FidĂȘncio
On Fri, Jun 3, 2016 at 2:03 PM, Frediano Ziglio wrote: > The segment_size computation on 32 bit can lead to big numbers which > can lead to negative offset. As we test we don't overrun the buffer > avoid to underrun it as we don't have a check for this. The last sentence in the commit message is

[Spice-devel] [PATCH 2/2] avoid integer underflow under 32 bit architectures

2016-06-03 Thread Frediano Ziglio
The segment_size computation on 32 bit can lead to big numbers which can lead to negative offset. As we test we don't overrun the buffer avoid to underrun it as we don't have a check for this. Signed-off-by: Frediano Ziglio --- server/red-parse-qxl.c | 3 +++ 1 file changed, 3 insertions(+) dif