Re: [Spice-devel] [PATCH 2/2] Remove all usages of bzero()

2012-02-14 Thread Dan McGee
On Tue, Feb 14, 2012 at 10:18 AM, Alon Levy wrote: > On Tue, Feb 14, 2012 at 09:57:55AM -0600, Dan McGee wrote: >> As recommended by modern C practice, we should just be using memset(). > > Sorry for the lack of knowledge, but can you point to the > recommendation? >From `man bzero` on my Linux b

Re: [Spice-devel] [PATCH 2/2] Remove all usages of bzero()

2012-02-14 Thread Alon Levy
On Tue, Feb 14, 2012 at 09:57:55AM -0600, Dan McGee wrote: > As recommended by modern C practice, we should just be using memset(). > nm my previous remark, man page is pretty clear. ACK both. > Signed-off-by: Dan McGee > --- > server/tests/basic_event_loop.c |2 +- > server/tests/test_

Re: [Spice-devel] [PATCH 2/2] Remove all usages of bzero()

2012-02-14 Thread Alon Levy
On Tue, Feb 14, 2012 at 09:57:55AM -0600, Dan McGee wrote: > As recommended by modern C practice, we should just be using memset(). Sorry for the lack of knowledge, but can you point to the recommendation? > > Signed-off-by: Dan McGee > --- > server/tests/basic_event_loop.c |2 +- > serv

[Spice-devel] [PATCH 2/2] Remove all usages of bzero()

2012-02-14 Thread Dan McGee
As recommended by modern C practice, we should just be using memset(). Signed-off-by: Dan McGee --- server/tests/basic_event_loop.c |2 +- server/tests/test_display_base.c |6 +++--- server/tests/test_empty_success.c |4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff