Re: [Spice-devel] [PATCH 18/18] worker: remove redundant check

2015-11-25 Thread Pavel Grunt
On Wed, 2015-11-25 at 09:30 -0500, Frediano Ziglio wrote: > > > > On Tue, 2015-11-24 at 11:13 +, Frediano Ziglio wrote: > > > From: Marc-André Lureau > > > > > > The check is done in draw() > > I don't see it in display_channel_draw(), it also prevented calling > > notify_update(). > > > >

Re: [Spice-devel] [PATCH 18/18] worker: remove redundant check

2015-11-25 Thread Frediano Ziglio
> > On Tue, 2015-11-24 at 11:13 +, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > The check is done in draw() > I don't see it in display_channel_draw(), it also prevented calling > notify_update(). > > I think the patch should be dropped. > > Pavel > > Reviewed-by: Pavel Grun

Re: [Spice-devel] [PATCH 18/18] worker: remove redundant check

2015-11-24 Thread Pavel Grunt
On Tue, 2015-11-24 at 11:13 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > The check is done in draw() I don't see it in display_channel_draw(), it also prevented calling notify_update(). I think the patch should be dropped. Pavel Reviewed-by: Pavel Grunt > --- >  server/red_work

[Spice-devel] [PATCH 18/18] worker: remove redundant check

2015-11-24 Thread Frediano Ziglio
From: Marc-André Lureau The check is done in draw() --- server/red_worker.c | 4 1 file changed, 4 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 4cc9fe9..a9fbd64 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -647,10 +647,6 @@ static int red_proce