Re: [Spice-devel] [PATCH 14/14] Convert RedChannel heirarchy to GObject

2016-05-09 Thread Jonathon Jongsma
On Mon, 2016-05-09 at 10:36 +0100, Daniel P. Berrange wrote: > On Wed, May 04, 2016 at 04:30:35AM -0400, Frediano Ziglio wrote: > > A patch of this size cannot be accepted, no matter how good it is. > > We need to find a way to split it. > > > > Any proposal would be good. > > There's some simple

Re: [Spice-devel] [PATCH 14/14] Convert RedChannel heirarchy to GObject

2016-05-09 Thread Daniel P. Berrange
On Wed, May 04, 2016 at 04:30:35AM -0400, Frediano Ziglio wrote: > A patch of this size cannot be accepted, no matter how good it is. > We need to find a way to split it. > > Any proposal would be good. There's some simple things which could be done ahead of the main conversion to GObject. - AP

Re: [Spice-devel] [PATCH 14/14] Convert RedChannel heirarchy to GObject

2016-05-04 Thread Jonathon Jongsma
On Wed, 2016-05-04 at 04:30 -0400, Frediano Ziglio wrote: > A patch of this size cannot be accepted, no matter how good it is. > We need to find a way to split it. > > Any proposal would be good. > > Frediano Yeah, I will attempt a split. Fortunately, the large patches are at the end of the ser

Re: [Spice-devel] [PATCH 14/14] Convert RedChannel heirarchy to GObject

2016-05-04 Thread Frediano Ziglio
A patch of this size cannot be accepted, no matter how good it is. We need to find a way to split it. Any proposal would be good. Frediano > > When using private structs with GObject, there's a maximum size of (I > think) 64k, which was exceeded by the DisplayChannel object. To make > this work