Re: [Spice-devel] [PATCH 12/17] Convert message writing from C style to C++ style

2018-02-26 Thread Christophe de Dinechin
Good idea. Will do it that way. > On 26 Feb 2018, at 11:05, Lukáš Hrázký wrote: > > Get rid of the 'make()' method and the 'msg' member, create the payload > on the stack in 'write()' and write the header and message in two > writes. > --- > It does split the write for FormatMessage into two, bu

Re: [Spice-devel] [PATCH 12/17] Convert message writing from C style to C++ style

2018-02-26 Thread Lukáš Hrázký
Get rid of the 'make()' method and the 'msg' member, create the payload on the stack in 'write()' and write the header and message in two writes. --- It does split the write for FormatMessage into two, but makes the code a bit simpler I think. It reduces the number of combinations the messages are

Re: [Spice-devel] [PATCH 12/17] Convert message writing from C style to C++ style

2018-02-26 Thread Lukáš Hrázký
On Fri, 2018-02-23 at 19:07 +0100, Christophe de Dinechin wrote: > > On 23 Feb 2018, at 17:37, Jonathon Jongsma wrote: > > > > On Fri, 2018-02-23 at 12:36 +0100, Christophe de Dinechin wrote: > > > > On 22 Feb 2018, at 19:05, Lukáš Hrázký wrote: > > > > > > > > On Thu, 2018-02-22 at 18:51 +0100

Re: [Spice-devel] [PATCH 12/17] Convert message writing from C style to C++ style

2018-02-23 Thread Christophe de Dinechin
> On 23 Feb 2018, at 17:37, Jonathon Jongsma wrote: > > On Fri, 2018-02-23 at 12:36 +0100, Christophe de Dinechin wrote: >>> On 22 Feb 2018, at 19:05, Lukáš Hrázký wrote: >>> >>> On Thu, 2018-02-22 at 18:51 +0100, Christophe de Dinechin wrote: > On 21 Feb 2018, at 10:45, Lukáš Hrázký >>>

Re: [Spice-devel] [PATCH 12/17] Convert message writing from C style to C++ style

2018-02-23 Thread Jonathon Jongsma
On Fri, 2018-02-23 at 12:36 +0100, Christophe de Dinechin wrote: > > On 22 Feb 2018, at 19:05, Lukáš Hrázký wrote: > > > > On Thu, 2018-02-22 at 18:51 +0100, Christophe de Dinechin wrote: > > > > On 21 Feb 2018, at 10:45, Lukáš Hrázký > > > > wrote: > > > > > > > > On Tue, 2018-02-20 at 16:41 +

Re: [Spice-devel] [PATCH 12/17] Convert message writing from C style to C++ style

2018-02-23 Thread Christophe de Dinechin
> On 22 Feb 2018, at 19:05, Lukáš Hrázký wrote: > > On Thu, 2018-02-22 at 18:51 +0100, Christophe de Dinechin wrote: >>> On 21 Feb 2018, at 10:45, Lukáš Hrázký wrote: >>> >>> On Tue, 2018-02-20 at 16:41 +0100, Christophe de Dinechin wrote: > On 20 Feb 2018, at 15:29, Lukáš Hrázký wrote:

Re: [Spice-devel] [PATCH 12/17] Convert message writing from C style to C++ style

2018-02-22 Thread Lukáš Hrázký
On Thu, 2018-02-22 at 18:51 +0100, Christophe de Dinechin wrote: > > On 21 Feb 2018, at 10:45, Lukáš Hrázký wrote: > > > > On Tue, 2018-02-20 at 16:41 +0100, Christophe de Dinechin wrote: > > > > On 20 Feb 2018, at 15:29, Lukáš Hrázký wrote: > > > > > > > > On Fri, 2018-02-16 at 17:15 +0100, Ch

Re: [Spice-devel] [PATCH 12/17] Convert message writing from C style to C++ style

2018-02-22 Thread Christophe de Dinechin
> On 21 Feb 2018, at 10:45, Lukáš Hrázký wrote: > > On Tue, 2018-02-20 at 16:41 +0100, Christophe de Dinechin wrote: >>> On 20 Feb 2018, at 15:29, Lukáš Hrázký wrote: >>> >>> On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: From: Christophe de Dinechin - The S

Re: [Spice-devel] [PATCH 12/17] Convert message writing from C style to C++ style

2018-02-21 Thread Lukáš Hrázký
On Tue, 2018-02-20 at 16:41 +0100, Christophe de Dinechin wrote: > > On 20 Feb 2018, at 15:29, Lukáš Hrázký wrote: > > > > On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: > > > From: Christophe de Dinechin > > > > > > - The Stream class now deals with locking and sending messag

Re: [Spice-devel] [PATCH 12/17] Convert message writing from C style to C++ style

2018-02-20 Thread Frediano Ziglio
> From: Christophe de Dinechin > > - The Stream class now deals with locking and sending messages > - The Message<> template class deals with the general writing mechanisms > - Three classes, FormatMessage, FrameMessage and X11CursorMessage represent > individual messages > > The various classes

Re: [Spice-devel] [PATCH 12/17] Convert message writing from C style to C++ style

2018-02-20 Thread Christophe de Dinechin
> On 20 Feb 2018, at 15:29, Lukáš Hrázký wrote: > > On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: >> From: Christophe de Dinechin >> >> - The Stream class now deals with locking and sending messages >> - The Message<> template class deals with the general writing mechanisms

Re: [Spice-devel] [PATCH 12/17] Convert message writing from C style to C++ style

2018-02-20 Thread Lukáš Hrázký
On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > - The Stream class now deals with locking and sending messages > - The Message<> template class deals with the general writing mechanisms > - Three classes, FormatMessage, FrameMessage and X11Curso

[Spice-devel] [PATCH 12/17] Convert message writing from C style to C++ style

2018-02-16 Thread Christophe de Dinechin
From: Christophe de Dinechin - The Stream class now deals with locking and sending messages - The Message<> template class deals with the general writing mechanisms - Three classes, FormatMessage, FrameMessage and X11CursorMessage represent individual messages The various classes should be move