Re: [Spice-devel] [PATCH 11/17] Move read, write and locking into the 'Stream' class

2018-02-21 Thread Jonathon Jongsma
On Wed, 2018-02-21 at 10:19 +0100, Lukáš Hrázký wrote: > > > > I chose short names because I was in that namespace. Otherwise, > > > > I > > > > agree with you. > > > > > > > > Do you think that the name is still too vague even within the > > > > namespace? > > > > > > I think so. Everything in s

Re: [Spice-devel] [PATCH 11/17] Move read, write and locking into the 'Stream' class

2018-02-21 Thread Lukáš Hrázký
On Tue, 2018-02-20 at 15:24 -0600, Jonathon Jongsma wrote: > On Tue, 2018-02-20 at 14:29 +0100, Lukáš Hrázký wrote: > > On Tue, 2018-02-20 at 10:47 +0100, Christophe de Dinechin wrote: > > > > On 20 Feb 2018, at 10:43, Lukáš Hrázký > > > > wrote: > > > > > > > > On Fri, 2018-02-16 at 17:15 +0100,

Re: [Spice-devel] [PATCH 11/17] Move read, write and locking into the 'Stream' class

2018-02-21 Thread Christophe de Dinechin
> On 20 Feb 2018, at 22:24, Jonathon Jongsma wrote: > > On Tue, 2018-02-20 at 14:29 +0100, Lukáš Hrázký wrote: >> On Tue, 2018-02-20 at 10:47 +0100, Christophe de Dinechin wrote: On 20 Feb 2018, at 10:43, Lukáš Hrázký wrote: On Fri, 2018-02-16 at 17:15 +0100, Christophe de

Re: [Spice-devel] [PATCH 11/17] Move read, write and locking into the 'Stream' class

2018-02-20 Thread Jonathon Jongsma
On Tue, 2018-02-20 at 14:29 +0100, Lukáš Hrázký wrote: > On Tue, 2018-02-20 at 10:47 +0100, Christophe de Dinechin wrote: > > > On 20 Feb 2018, at 10:43, Lukáš Hrázký > > > wrote: > > > > > > On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: > > > > From: Christophe de Dinechin >

Re: [Spice-devel] [PATCH 11/17] Move read, write and locking into the 'Stream' class

2018-02-20 Thread Lukáš Hrázký
On Tue, 2018-02-20 at 10:47 +0100, Christophe de Dinechin wrote: > > On 20 Feb 2018, at 10:43, Lukáš Hrázký wrote: > > > > On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: > > > From: Christophe de Dinechin > > > > > > Signed-off-by: Christophe de Dinechin > > > --- > > > src/s

Re: [Spice-devel] [PATCH 11/17] Move read, write and locking into the 'Stream' class

2018-02-20 Thread Christophe de Dinechin
> On 20 Feb 2018, at 10:43, Lukáš Hrázký wrote: > > On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: >> From: Christophe de Dinechin >> >> Signed-off-by: Christophe de Dinechin >> --- >> src/spice-streaming-agent.cpp | 86 >> +++ >> 1 f

Re: [Spice-devel] [PATCH 11/17] Move read, write and locking into the 'Stream' class

2018-02-20 Thread Lukáš Hrázký
On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > src/spice-streaming-agent.cpp | 86 > +++ > 1 file changed, 47 insertions(+), 39 deletions(-) > > diff --gi

[Spice-devel] [PATCH 11/17] Move read, write and locking into the 'Stream' class

2018-02-16 Thread Christophe de Dinechin
From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 86 +++ 1 file changed, 47 insertions(+), 39 deletions(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index f0d79ae..a98