Re: [Spice-devel] [PATCH 10/10] Change RedCharDevicePrivate::clients to GList

2016-09-12 Thread Frediano Ziglio
> > HHey, > > On Fri, Sep 09, 2016 at 10:47:12AM -0400, Frediano Ziglio wrote: > > > > > > More Ring cleanup > > > > Personally I don't approve the rationale. > > > > Rings are used by Qemu and Linux kernel, Qemu calls us directly and > > we deal with Linux too. Not counting all BSD code. So s

Re: [Spice-devel] [PATCH 10/10] Change RedCharDevicePrivate::clients to GList

2016-09-09 Thread Jonathon Jongsma
On Fri, 2016-09-09 at 17:03 +0200, Christophe Fergeau wrote: > HHey, > > On Fri, Sep 09, 2016 at 10:47:12AM -0400, Frediano Ziglio wrote: > > > > > > > > > > > More Ring cleanup > > > > Personally I don't approve the rationale. > > > > Rings are used by Qemu and Linux kernel, Qemu calls us di

Re: [Spice-devel] [PATCH 10/10] Change RedCharDevicePrivate::clients to GList

2016-09-09 Thread Christophe Fergeau
HHey, On Fri, Sep 09, 2016 at 10:47:12AM -0400, Frediano Ziglio wrote: > > > > More Ring cleanup > > Personally I don't approve the rationale. > > Rings are used by Qemu and Linux kernel, Qemu calls us directly and > we deal with Linux too. Not counting all BSD code. So surely are not > less te

Re: [Spice-devel] [PATCH 10/10] Change RedCharDevicePrivate::clients to GList

2016-09-09 Thread Frediano Ziglio
> > More Ring cleanup Personally I don't approve the rationale. Rings are used by Qemu and Linux kernel, Qemu calls us directly and we deal with Linux too. Not counting all BSD code. So surely are not less tested and maintained then glib code. Rings are not less readable or less type safe then G

Re: [Spice-devel] [PATCH 10/10] Change RedCharDevicePrivate::clients to GList

2016-09-09 Thread Christophe Fergeau
On Thu, Sep 08, 2016 at 11:53:00AM -0500, Jonathon Jongsma wrote: > More Ring cleanup > --- > server/char-device.c | 72 > ++-- > 1 file changed, 30 insertions(+), 42 deletions(-) > > diff --git a/server/char-device.c b/server/char-device.c > index

[Spice-devel] [PATCH 10/10] Change RedCharDevicePrivate::clients to GList

2016-09-08 Thread Jonathon Jongsma
More Ring cleanup --- server/char-device.c | 72 ++-- 1 file changed, 30 insertions(+), 42 deletions(-) diff --git a/server/char-device.c b/server/char-device.c index e01f34c..40512f8 100644 --- a/server/char-device.c +++ b/server/char-device.c @@ -