Re: [Spice-devel] [PATCH 1/9] Move some tree item functions to tree.[ch]

2015-11-17 Thread Jonathon Jongsma
ACK On Tue, 2015-11-17 at 12:07 -0500, Frediano Ziglio wrote: > Also rename some functions slightly: > __find_shadow -> tree_item_find_shadow() > __contained_by -> tree_item_contained_by() > ring_of -> tree_item_container_items(); > > Acked-by: Fabiano FidĂȘncio > --- > server/red

Re: [Spice-devel] [PATCH 1/9] Move some tree item functions to tree.[ch]

2015-11-17 Thread Frediano Ziglio
Also rename some functions slightly: __find_shadow -> tree_item_find_shadow() __contained_by -> tree_item_contained_by() ring_of -> tree_item_container_items(); Acked-by: Fabiano FidĂȘncio --- server/red_worker.c | 62 ++--- server/tr

Re: [Spice-devel] [PATCH 1/9] Move some tree item functions to tree.[ch]

2015-11-17 Thread Jonathon Jongsma
Hmm, it doesn't seem that this patch changed since the last version you sent. Except some of the context is slightly different, perhaps because of re -ordering? (e.g. exclude_region has a RedWorker* as the first parameter in this patch. In the previous patch, it had DisplayChannel* as the first par

[Spice-devel] [PATCH 1/9] Move some tree item functions to tree.[ch]

2015-11-17 Thread Frediano Ziglio
From: Jonathon Jongsma Also rename some functions slightly: __find_shadow -> tree_item_find_shadow() __contained_by -> tree_item_contained_by() ring_of -> tree_item_container_items(); Acked-by: Fabiano FidĂȘncio --- server/red_worker.c | 62 ++-