Re: [Spice-devel] [PATCH 1/3] usb: use native libusb procedure for getting error name

2019-05-07 Thread Victor Toso
Hi, On Tue, Apr 16, 2019 at 08:51:52AM +, Victor Toso wrote: > Hi, > > On Mon, Apr 15, 2019 at 03:42:05PM +0300, Yuri Benditovich wrote: > > IIUC, what you call 'simpler' is: > > - making unneeded changes in several files (instead of one) > > - in the next patch remove these changes completel

Re: [Spice-devel] [PATCH 1/3] usb: use native libusb procedure for getting error name

2019-04-16 Thread Victor Toso
Hi, On Mon, Apr 15, 2019 at 03:42:05PM +0300, Yuri Benditovich wrote: > IIUC, what you call 'simpler' is: > - making unneeded changes in several files (instead of one) > - in the next patch remove these changes completely > > Did I miss something? Current patch series changes spice_usbutil_libus

Re: [Spice-devel] [PATCH 1/3] usb: use native libusb procedure for getting error name

2019-04-15 Thread Christophe Fergeau
On Mon, Apr 15, 2019 at 03:42:05PM +0300, Yuri Benditovich wrote: > IIUC, what you call 'simpler' is: > - making unneeded changes in several files (instead of one) > - in the next patch remove these changes completely > > Did I miss something? Ah I did not look at the next patches :) Since you in

Re: [Spice-devel] [PATCH 1/3] usb: use native libusb procedure for getting error name

2019-04-15 Thread Yuri Benditovich
IIUC, what you call 'simpler' is: - making unneeded changes in several files (instead of one) - in the next patch remove these changes completely Did I miss something? On Mon, Apr 15, 2019 at 3:18 PM Christophe Fergeau wrote: > > On Thu, Apr 11, 2019 at 12:37:17PM +, Victor Toso wrote: > >

Re: [Spice-devel] [PATCH 1/3] usb: use native libusb procedure for getting error name

2019-04-15 Thread Christophe Fergeau
On Thu, Apr 11, 2019 at 12:37:17PM +, Victor Toso wrote: > Hi, > > On Thu, Apr 11, 2019 at 02:57:21PM +0300, Yuri Benditovich wrote: > > On Thu, Apr 11, 2019 at 12:35 PM Victor Toso wrote: > > > > > > Hi, > > > > > > On Wed, Apr 10, 2019 at 10:31:37PM +0300, Yuri Benditovich wrote: > > > > li

Re: [Spice-devel] [PATCH 1/3] usb: use native libusb procedure for getting error name

2019-04-11 Thread Victor Toso
Hi, On Thu, Apr 11, 2019 at 02:57:21PM +0300, Yuri Benditovich wrote: > On Thu, Apr 11, 2019 at 12:35 PM Victor Toso wrote: > > > > Hi, > > > > On Wed, Apr 10, 2019 at 10:31:37PM +0300, Yuri Benditovich wrote: > > > libusb has libusb_error_name procedure that returns name > > > for any error that

Re: [Spice-devel] [PATCH 1/3] usb: use native libusb procedure for getting error name

2019-04-11 Thread Yuri Benditovich
On Thu, Apr 11, 2019 at 12:35 PM Victor Toso wrote: > > Hi, > > On Wed, Apr 10, 2019 at 10:31:37PM +0300, Yuri Benditovich wrote: > > libusb has libusb_error_name procedure that returns name > > for any error that libusb may return, so we do not need > > to analyze error values by ourselves. > > >

Re: [Spice-devel] [PATCH 1/3] usb: use native libusb procedure for getting error name

2019-04-11 Thread Victor Toso
Hi, On Wed, Apr 10, 2019 at 10:31:37PM +0300, Yuri Benditovich wrote: > libusb has libusb_error_name procedure that returns name > for any error that libusb may return, so we do not need > to analyze error values by ourselves. > > Signed-off-by: Yuri Benditovich Before applying the series: (ma

[Spice-devel] [PATCH 1/3] usb: use native libusb procedure for getting error name

2019-04-10 Thread Yuri Benditovich
libusb has libusb_error_name procedure that returns name for any error that libusb may return, so we do not need to analyze error values by ourselves. Signed-off-by: Yuri Benditovich --- src/usbutil.c | 32 +--- 1 file changed, 1 insertion(+), 31 deletions(-) diff --