Re: [Spice-devel] [PATCH 1/2] server: remove dispatching creation of worker channels

2015-11-09 Thread Frediano Ziglio
> > The commit log is a bit terse and difficult to parse, but the patch > looks OK. It's clearly an intermediate step in a refactoring, but > that's OK. > > Possible suggestion for commit log: > > "Create display and cursor channels in RedWorker constructor > > Instead of requiring the dispatc

Re: [Spice-devel] [PATCH 1/2] server: remove dispatching creation of worker channels

2015-11-06 Thread Jonathon Jongsma
The commit log is a bit terse and difficult to parse, but the patch looks OK. It's clearly an intermediate step in a refactoring, but that's OK. Possible suggestion for commit log: "Create display and cursor channels in RedWorker constructor Instead of requiring the dispatcher to send a message

[Spice-devel] [PATCH 1/2] server: remove dispatching creation of worker channels

2015-11-06 Thread Frediano Ziglio
From: Marc-André Lureau --- server/red_dispatcher.c | 74 +++-- server/red_dispatcher.h | 4 +-- server/red_worker.c | 68 +++-- server/red_worker.h | 2 ++ 4 files changed, 48 insertions(+), 100 deleti