Re: [Spice-devel] [PATCH 1/2] server: don't fail on ENOPROTOOPT from setsockopt

2012-03-12 Thread Nahum Shalman
Before I get too far into changing lots of code I wanted to ask the following questions: spice/server]$ git grep "setsockopt(" | wc -l 10 There are 10 calls to setsockopt in the server code base. All of them allow ENOTSUP, and won't even complain if they get that error code. Only the two that

Re: [Spice-devel] [PATCH 1/2] server: don't fail on ENOPROTOOPT from setsockopt

2012-03-10 Thread Alon Levy
On Fri, Mar 09, 2012 at 12:26:50PM -0500, Nahum Shalman wrote: > If we allow listening on arbitrary sockets like unix sockets, > we can get ENOPROTOOPT errors from setsockopt calls that set TCP > specific options. This should be allowed to happen. I'm a little concerned that we will ignore actual

Re: [Spice-devel] [PATCH 1/2] server: don't fail on ENOPROTOOPT from setsockopt

2012-03-09 Thread Daniel P. Berrange
On Fri, Mar 09, 2012 at 12:26:50PM -0500, Nahum Shalman wrote: > If we allow listening on arbitrary sockets like unix sockets, > we can get ENOPROTOOPT errors from setsockopt calls that set TCP > specific options. This should be allowed to happen. > --- > server/inputs_channel.c |2 +- > serv

[Spice-devel] [PATCH 1/2] server: don't fail on ENOPROTOOPT from setsockopt

2012-03-09 Thread Nahum Shalman
If we allow listening on arbitrary sockets like unix sockets, we can get ENOPROTOOPT errors from setsockopt calls that set TCP specific options. This should be allowed to happen. --- server/inputs_channel.c |2 +- server/spicevmc.c |2 +- 2 files changed, 2 insertions(+), 2 deletion