On Tue, Aug 16, 2011 at 02:53:47PM +0200, Christophe Fergeau wrote:
I can't comment about the second patch except it looks great to drop
15 lines for 2, so
ACK both.
> InputsChannel::handle_modifiers converts _modifiers which is a
> bitflag of SPICE_KEYBOARD_MODIFIER_FLAGS_* to a Platform::*_MOD
InputsChannel::handle_modifiers converts _modifiers which is a
bitflag of SPICE_KEYBOARD_MODIFIER_FLAGS_* to a Platform::*_MODIFIER
bitflag, which is what Platform::set_keyboard_lock_modifiers expects.
However, it's called with _modifiers, and the bitflag that this
function computes is never used.
