Re: [Spice-devel] [PATCH 1/1] Add API to turn on backwards compatibility mode

2010-08-30 Thread Gerd Hoffmann
On 08/27/10 19:42, Alexander Larsson wrote: On Fri, 2010-08-27 at 17:28 +0200, Gerd Hoffmann wrote: Hi, Having a more fine-grained command line feature selection just causes complexity and risk that sysadmins get things wrong. I don't see any gain in it. Point. I'll note that this switch i

Re: [Spice-devel] [PATCH 1/1] Add API to turn on backwards compatibility mode

2010-08-27 Thread Alexander Larsson
On Fri, 2010-08-27 at 17:28 +0200, Gerd Hoffmann wrote: > Hi, > > > Having a more fine-grained command line feature selection just causes > > complexity and risk that sysadmins get things wrong. I don't see any > > gain in it. > > Point. > > > I'll note that this switch is really only about migr

Re: [Spice-devel] [PATCH 1/1] Add API to turn on backwards compatibility mode

2010-08-27 Thread Gerd Hoffmann
Hi, Having a more fine-grained command line feature selection just causes complexity and risk that sysadmins get things wrong. I don't see any gain in it. Point. I'll note that this switch is really only about migration compatibility. Any reason to add this now? We could delay it until

Re: [Spice-devel] [PATCH 1/1] Add API to turn on backwards compatibility mode

2010-08-27 Thread Alexander Larsson
On Fri, 2010-08-27 at 15:08 +0200, Gerd Hoffmann wrote: > >> As you are talking about "set of features" already ... > >> > >> I think we should use a feature bitmask instead of a version number in > >> the API. > > > > How would you use this in qemu though? Say you link to spice 0.10.0, > > which h

Re: [Spice-devel] [PATCH 1/1] Add API to turn on backwards compatibility mode

2010-08-27 Thread Gerd Hoffmann
As you are talking about "set of features" already ... I think we should use a feature bitmask instead of a version number in the API. How would you use this in qemu though? Say you link to spice 0.10.0, which has a set of new features not in 0.8.0. Why would you want to make a spice instance t

Re: [Spice-devel] [PATCH 1/1] Add API to turn on backwards compatibility mode

2010-08-27 Thread Alexander Larsson
On Fri, 2010-08-27 at 09:16 +0200, Gerd Hoffmann wrote: > Hi, > > > This API allows qemu to limit the set of features that spice uses to > > those compatible with an older version, in order to do an upgrade like > > this. Right now it doesn't really do much, since we don't keep compat > > with 0.4

Re: [Spice-devel] [PATCH 1/1] Add API to turn on backwards compatibility mode

2010-08-27 Thread Gerd Hoffmann
Hi, This API allows qemu to limit the set of features that spice uses to those compatible with an older version, in order to do an upgrade like this. Right now it doesn't really do much, since we don't keep compat with 0.4.0 atm (although that may be added later). As you are talking about "s

Re: [Spice-devel] [PATCH 1/1] Add API to turn on backwards compatibility mode

2010-08-26 Thread Alexander Larsson
On Thu, 2010-08-26 at 09:26 -0400, Alon Levy wrote: > - al...@redhat.com wrote: > > > From: Alexander Larsson > > > > When upgrading a cluster of machines you typically do this by > > upgrading a set of machines at a time, making the new machines run > > the new software version, but in a fa

Re: [Spice-devel] [PATCH 1/1] Add API to turn on backwards compatibility mode

2010-08-26 Thread Alon Levy
- al...@redhat.com wrote: > From: Alexander Larsson > > When upgrading a cluster of machines you typically do this by > upgrading a set of machines at a time, making the new machines run > the new software version, but in a fashion compatible with the old > versions (in terms of e.g. migrat

[Spice-devel] [PATCH 1/1] Add API to turn on backwards compatibility mode

2010-08-26 Thread alexl
From: Alexander Larsson When upgrading a cluster of machines you typically do this by upgrading a set of machines at a time, making the new machines run the new software version, but in a fashion compatible with the old versions (in terms of e.g. migration). Then when all machines are any new fea