Re: [Spice-devel] [PATCH 07/15] worker: make more functions static, kill dead function

2015-11-09 Thread Frediano Ziglio
> > On Mon, 2015-11-09 at 09:14 -0500, Frediano Ziglio wrote: > > > > > > Looks good, but I would split it to: > > > worker: make more functions static > > > worker: remove unused function > > > > > > Pavel > > > > > > > Giving that the warning from unused should be an error due to -Werror and

Re: [Spice-devel] [PATCH 07/15] worker: make more functions static, kill dead function

2015-11-09 Thread Pavel Grunt
On Mon, 2015-11-09 at 09:14 -0500, Frediano Ziglio wrote: > > > > Looks good, but I would split it to: > > worker: make more functions static > > worker: remove unused function > > > > Pavel > > > > Giving that the warning from unused should be an error due to -Werror and > the commit should no

Re: [Spice-devel] [PATCH 07/15] worker: make more functions static, kill dead function

2015-11-09 Thread Frediano Ziglio
> > Looks good, but I would split it to: > worker: make more functions static > worker: remove unused function > > Pavel > Giving that the warning from unused should be an error due to -Werror and the commit should not compile probably the order of the patch should be worker: remove unused fun

Re: [Spice-devel] [PATCH 07/15] worker: make more functions static, kill dead function

2015-11-09 Thread Pavel Grunt
Looks good, but I would split it to: worker: make more functions static worker: remove unused function Pavel On Mon, 2015-11-09 at 13:16 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- >  server/red_worker.c | 71 -- > --- >  1 file

[Spice-devel] [PATCH 07/15] worker: make more functions static, kill dead function

2015-11-09 Thread Frediano Ziglio
From: Marc-André Lureau --- server/red_worker.c | 71 - 1 file changed, 32 insertions(+), 39 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 8f6ef95..0c1a1b1 100644 --- a/server/red_worker.c +++ b/server/red_worker.c