Re: [Spice-devel] [PATCH 05/10] Add SmartCardChannelClientPrivate struct

2016-09-07 Thread Jonathon Jongsma
On Tue, 2016-09-06 at 08:18 -0400, Frediano Ziglio wrote: > > > > > > Hi, > > > > On Wed, Aug 31, 2016 at 11:54:41AM -0500, Jonathon Jongsma wrote: > > > > > > Prepare to port to GObject by encapsulating all private data > > > > If I'm not mistaken, the private struct now will leak while > > S

Re: [Spice-devel] [PATCH 05/10] Add SmartCardChannelClientPrivate struct

2016-09-06 Thread Frediano Ziglio
> > Hi, > > On Wed, Aug 31, 2016 at 11:54:41AM -0500, Jonathon Jongsma wrote: > > Prepare to port to GObject by encapsulating all private data > > If I'm not mistaken, the private struct now will leak while > SmartCardChannelClient is not a GObject with its finalize/dispose. > If that is the cas

Re: [Spice-devel] [PATCH 05/10] Add SmartCardChannelClientPrivate struct

2016-09-01 Thread Victor Toso
On Thu, Sep 01, 2016 at 11:22:52AM +0200, Victor Toso wrote: > Hi, > > On Wed, Aug 31, 2016 at 11:54:41AM -0500, Jonathon Jongsma wrote: > > Prepare to port to GObject by encapsulating all private data > > If I'm not mistaken, the private struct now will leak while > SmartCardChannelClient is not a

Re: [Spice-devel] [PATCH 05/10] Add SmartCardChannelClientPrivate struct

2016-09-01 Thread Victor Toso
Hi, On Wed, Aug 31, 2016 at 11:54:41AM -0500, Jonathon Jongsma wrote: > Prepare to port to GObject by encapsulating all private data If I'm not mistaken, the private struct now will leak while SmartCardChannelClient is not a GObject with its finalize/dispose. If that is the case, might point it o

[Spice-devel] [PATCH 05/10] Add SmartCardChannelClientPrivate struct

2016-08-31 Thread Jonathon Jongsma
Prepare to port to GObject by encapsulating all private data --- server/smartcard.c | 87 +- 1 file changed, 47 insertions(+), 40 deletions(-) diff --git a/server/smartcard.c b/server/smartcard.c index 74c2b18..8d22be4 100644 --- a/server/smartc