Re: [Spice-devel] [PATCH 04/18] Make red_client_remove_channel() a RedClient method

2016-04-29 Thread Frediano Ziglio
> > On Thu, 2016-04-28 at 13:09 -0400, Frediano Ziglio wrote: > > > > > > Explicitly pass RedClient* as first argument to this function, to mirror > > > red_client_add_channel(). This will eventually allow us to separate the > > > implementations of RedClient and RedChannelClient so that they do

Re: [Spice-devel] [PATCH 04/18] Make red_client_remove_channel() a RedClient method

2016-04-28 Thread Jonathon Jongsma
On Thu, 2016-04-28 at 13:09 -0400, Frediano Ziglio wrote: > > > > Explicitly pass RedClient* as first argument to this function, to mirror > > red_client_add_channel(). This will eventually allow us to separate the > > implementations of RedClient and RedChannelClient so that they don't > > need t

Re: [Spice-devel] [PATCH 04/18] Make red_client_remove_channel() a RedClient method

2016-04-28 Thread Frediano Ziglio
> > Explicitly pass RedClient* as first argument to this function, to mirror > red_client_add_channel(). This will eventually allow us to separate the > implementations of RedClient and RedChannelClient so that they don't > need to be poking into the internals of each other's structs. I quite dis

[Spice-devel] [PATCH 04/18] Make red_client_remove_channel() a RedClient method

2016-04-27 Thread Jonathon Jongsma
Explicitly pass RedClient* as first argument to this function, to mirror red_client_add_channel(). This will eventually allow us to separate the implementations of RedClient and RedChannelClient so that they don't need to be poking into the internals of eachother's structs. --- server/red-channel.