Re: [Spice-devel] [PATCH] vd_agent: support clipboard/selection-owner model

2010-09-27 Thread Hans de Goede
Hi, On 09/26/2010 10:15 AM, Arnon Gilboa wrote: So far, the clipboard support was disabled in the agent side, so I see no real need for supporting the two different clipboard flows and complicating the behavior in both sides. I suggest removing the support for the "old clipboard" (VD_AGENT_CAP

Re: [Spice-devel] [PATCH] vd_agent: support clipboard/selection-owner model

2010-09-26 Thread Arnon Gilboa
So far, the clipboard support was disabled in the agent side, so I see no real need for supporting the two different clipboard flows and complicating the behavior in both sides. I suggest removing the support for the "old clipboard" (VD_AGENT_CAP_CLIPBOARD, which was unusable anyway), and using

Re: [Spice-devel] [PATCH] vd_agent: support clipboard/selection-owner model

2010-09-26 Thread Arnon Gilboa
Windows is not "waiting" for me to render. It just closes the clipboard. If we do nothing on receiving WM_RENDERALLFORMATS, the clipboard is actually kept empty, because using the delayed-rendering-way we have already called EmptyClipboard() in handle_clipboard_grab(). I think doing nothing is

Re: [Spice-devel] [PATCH] vd_agent: support clipboard/selection-owner model

2010-09-22 Thread Alexander Larsson
On Wed, 2010-09-22 at 11:45 +0200, Arnon Gilboa wrote: > MSDN is saying: "WM_RENDERALLFORMATS Message is sent to the clipboard > owner before it is destroyed, if the clipboard owner has delayed > rendering one or more clipboard formats. For the content of the > clipboard to remain available to o

Re: [Spice-devel] [PATCH] vd_agent: support clipboard/selection-owner model

2010-09-22 Thread Arnon Gilboa
MSDN is saying: "WM_RENDERALLFORMATS Message is sent to the clipboard owner before it is destroyed, if the clipboard owner has delayed rendering one or more clipboard formats. For the content of the clipboard to remain available to other applications, the clipboard owner must render data in all

Re: [Spice-devel] [PATCH] vd_agent: support clipboard/selection-owner model

2010-09-22 Thread Alexander Larsson
On Tue, 2010-09-21 at 19:16 +0200, Arnon Gilboa wrote: > -#endif // CLIPBOARD_ENABLED > +case WM_RENDERFORMAT: > +a->on_clipboard_render((UINT)wparam); > +break; > +case WM_RENDERALLFORMATS: > +vd_printf("WM_RENDERALLFORMATS"); > +break; I think you need to

Re: [Spice-devel] [PATCH] vd_agent: support clipboard/selection-owner model

2010-09-22 Thread Arnon Gilboa
Hi Hans, Thanks for your comments. I more than agree with all of them. I was simply anxious to demo the bitmap c&p with the win client, so added this win-specific format which required no coding, and is currently ignored by the linux client. Regarding the new clipboard capability bit & ifs, I

Re: [Spice-devel] [PATCH] vd_agent: support clipboard/selection-owner model

2010-09-22 Thread Hans de Goede
Hi, See comments inline. On 09/21/2010 07:16 PM, Arnon Gilboa wrote: -enable the clipboard support -support the GRAB/REQUEST/DATA/RELEASE verbs in both ways. -pasting clipboard data is now "only-by-demand" from both sides (client and agent), whose behavior is symmetric. -client and agent don't

[Spice-devel] [PATCH] vd_agent: support clipboard/selection-owner model

2010-09-21 Thread Arnon Gilboa
-enable the clipboard support -support the GRAB/REQUEST/DATA/RELEASE verbs in both ways. -pasting clipboard data is now "only-by-demand" from both sides (client and agent), whose behavior is symmetric. -client and agent don't read or send the contents of the clipboard unnecessarily (e.g. copy, in