Re: [Spice-devel] [PATCH] validate tcp port values

2012-07-16 Thread Uri Lublin
Hi Peter, On 07/16/2012 12:03 PM, Peter Hatina wrote: Review, please. Looks good to me, ack. Uri. --- SpiceXPI/src/plugin/plugin.cpp | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/SpiceXPI/src/plugin/plugin.cpp b/SpiceXPI/src/plugi

[Spice-devel] [PATCH] validate tcp port values

2012-07-16 Thread Peter Hatina
Review, please. --- SpiceXPI/src/plugin/plugin.cpp | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/SpiceXPI/src/plugin/plugin.cpp b/SpiceXPI/src/plugin/plugin.cpp index b7f61ba..cb4bc8e 100644 --- a/SpiceXPI/src/plugin/plugin.cpp +++ b/SpiceX

Re: [Spice-devel] [PATCH] validate tcp port values

2012-07-15 Thread Uri Lublin
On 07/12/2012 02:31 PM, Peter Hatina wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/11/2012 02:03 PM, Uri Lublin wrote: On 07/11/2012 02:03 PM, Peter Hatina wrote: Hi, I had a request to validate TCP port values in spice-xpi, so does this make sense for you? More info at https://

Re: [Spice-devel] [PATCH] validate tcp port values

2012-07-12 Thread Peter Hatina
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/11/2012 02:03 PM, Uri Lublin wrote: > On 07/11/2012 02:03 PM, Peter Hatina wrote: >> Hi, >> >> I had a request to validate TCP port values in spice-xpi, so does >> this make sense for you? >> >> More info at https://bugzilla.redhat.com/show_bug

Re: [Spice-devel] [PATCH] validate tcp port values

2012-07-11 Thread Uri Lublin
On 07/11/2012 02:03 PM, Peter Hatina wrote: Hi, I had a request to validate TCP port values in spice-xpi, so does this make sense for you? More info at https://bugzilla.redhat.com/show_bug.cgi?id=805602 --- SpiceXPI/src/plugin/plugin.cpp | 27 +-- 1 file changed, 2

Re: [Spice-devel] [PATCH] validate tcp port values

2012-07-11 Thread Peter Hatina
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, On 07/11/2012 01:41 PM, Christophe Fergeau wrote: > On Wed, Jul 11, 2012 at 01:03:28PM +0200, Peter Hatina wrote: >> Hi, >> >> I had a request to validate TCP port values in spice-xpi, so does >> this make sense for you? > > This sounds like a g

Re: [Spice-devel] [PATCH] validate tcp port values

2012-07-11 Thread Alon Levy
On Wed, Jul 11, 2012 at 01:03:28PM +0200, Peter Hatina wrote: > Hi, > > I had a request to validate TCP port values in spice-xpi, so > does this make sense for you? > > More info at https://bugzilla.redhat.com/show_bug.cgi?id=805602 > > --- > SpiceXPI/src/plugin/plugin.cpp | 27 ++

Re: [Spice-devel] [PATCH] validate tcp port values

2012-07-11 Thread Christophe Fergeau
On Wed, Jul 11, 2012 at 01:03:28PM +0200, Peter Hatina wrote: > Hi, > > I had a request to validate TCP port values in spice-xpi, so > does this make sense for you? This sounds like a good thing to do, though spice-xpi is just a gateway here between ovirt/rhev and remote-viewer, so the validation

[Spice-devel] [PATCH] validate tcp port values

2012-07-11 Thread Peter Hatina
Hi, I had a request to validate TCP port values in spice-xpi, so does this make sense for you? More info at https://bugzilla.redhat.com/show_bug.cgi?id=805602 --- SpiceXPI/src/plugin/plugin.cpp | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/Sp