Re: [Spice-devel] [PATCH] smartcard: do not keep weak ref when device is NULL

2019-01-29 Thread Frediano Ziglio
> > When a client disconnects, smartcard_channel_client_set_char_device > is called with a NULL "device" argument. In that case there is > no need to take a weak reference to the device. > > Without this patch the server complains: > g_object_add_weak_pointer: assertion 'G_IS_OBJECT (object)' f

[Spice-devel] [PATCH] smartcard: do not keep weak ref when device is NULL

2019-01-29 Thread Uri Lublin
When a client disconnects, smartcard_channel_client_set_char_device is called with a NULL "device" argument. In that case there is no need to take a weak reference to the device. Without this patch the server complains: g_object_add_weak_pointer: assertion 'G_IS_OBJECT (object)' failed and abor