Re: [Spice-devel] [PATCH] server: add async io support

2011-07-07 Thread Gerd Hoffmann
Hi, void (*surface_updated)(QXLInstance *qxl, uint32_t surface_id, struct QXLRect *rect) Looks good. heh - I changed it to a list of rects instead of one in the patch I sent. Do you think a single is better? A list is fine too and I think it actually is even better. We can use also th

Re: [Spice-devel] [PATCH] server: add async io support

2011-07-07 Thread Alon Levy
On Thu, Jul 07, 2011 at 09:07:53AM +0200, Gerd Hoffmann wrote: > Hi, > > >>While we are busy updating the interface: can we please also add a > >>callback which is called by spice server each time it updates a > >>surface in qxl device memory? > >you mean whenever we render something? I guess I'

Re: [Spice-devel] [PATCH] server: add async io support

2011-07-07 Thread Gerd Hoffmann
Hi, While we are busy updating the interface: can we please also add a callback which is called by spice server each time it updates a surface in qxl device memory? you mean whenever we render something? I guess I'll allow it to be NULL at first cause I don't want to bother implementing it on

Re: [Spice-devel] [PATCH] server: add async io support

2011-07-06 Thread Alon Levy
On Wed, Jul 06, 2011 at 02:42:03PM +0200, Gerd Hoffmann wrote: > Hi, > > >diff --git a/server/spice.h b/server/spice.h > >index f64ff41..f0d5685 100644 > >--- a/server/spice.h > >+++ b/server/spice.h > >@@ -122,6 +122,17 @@ struct QXLWorker { > > void (*reset_cursor)(QXLWorker *worker); > >

Re: [Spice-devel] [PATCH] server: add async io support

2011-07-06 Thread Gerd Hoffmann
Hi, diff --git a/server/spice.h b/server/spice.h index f64ff41..f0d5685 100644 --- a/server/spice.h +++ b/server/spice.h @@ -122,6 +122,17 @@ struct QXLWorker { void (*reset_cursor)(QXLWorker *worker); void (*destroy_surface_wait)(QXLWorker *worker, uint32_t surface_id); void

[Spice-devel] [PATCH] server: add async io support

2011-07-06 Thread Alon Levy
The new _ASYNC io's in qxl_dev listed at the end get six new api functions, and an additional callback function "async_complete". When the async version of a specific io is used, completion is notified by calling async_complete, and no READY message is written or expected by the dispatcher. update