Re: [Spice-devel] [PATCH] server/red_dispatcher: fix memset params

2011-08-02 Thread Alon Levy
On Tue, Aug 02, 2011 at 11:55:53AM +0200, Christophe Fergeau wrote: > Hey Uri, > > Good catch! How did you find it? valgrind? static analysis? Code > review? > > On Tue, Aug 02, 2011 at 11:05:11AM +0300, Uri Lublin wrote: > > update_client_mouse_allowed(); > > -memset(&dispatcher->surfac

Re: [Spice-devel] [PATCH] server/red_dispatcher: fix memset params

2011-08-02 Thread Christophe Fergeau
Hey Uri, Good catch! How did you find it? valgrind? static analysis? Code review? On Tue, Aug 02, 2011 at 11:05:11AM +0300, Uri Lublin wrote: > update_client_mouse_allowed(); > -memset(&dispatcher->surface_create, sizeof(QXLDevSurfaceCreate), 0); > +memset(&dispatcher->surface_create

Re: [Spice-devel] [PATCH] server/red_dispatcher: fix memset params

2011-08-02 Thread Alon Levy
On Tue, Aug 02, 2011 at 11:05:11AM +0300, Uri Lublin wrote: > Replace wrong memset(ptr, size, 0) > With memset(ptr, 0, size) ACK. Thanks for catching this. > --- > server/red_dispatcher.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/server/red_dispatcher.c b/se

[Spice-devel] [PATCH] server/red_dispatcher: fix memset params

2011-08-02 Thread Uri Lublin
Replace wrong memset(ptr, size, 0) With memset(ptr, 0, size) --- server/red_dispatcher.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/server/red_dispatcher.c b/server/red_dispatcher.c index 8f4a8a8..f86da81 100644 --- a/server/red_dispatcher.c +++ b/server/red_dispatch