Re: [Spice-devel] [PATCH] remove dandling pointer for RedCharDeviceVDIPort

2016-05-05 Thread Uri Lublin
On 05/04/2016 11:51 AM, Frediano Ziglio wrote: On 05/03/2016 01:53 PM, Frediano Ziglio wrote: On 05/02/2016 11:25 AM, Frediano Ziglio wrote: This was caused by commit 1cec1c5118b65124de6bc6f984f376ff4e297bfb ("reds: Make VDIPortState a GObject") as the lifespan of RedCharDevice was changed.

Re: [Spice-devel] [PATCH] remove dandling pointer for RedCharDeviceVDIPort

2016-05-04 Thread Eduardo Lima (Etrunko)
On 05/04/2016 05:51 AM, Frediano Ziglio wrote: >> >>> >>> Honestly more I look at the patch and this fix and more I think it's all >>> a big bug... >>> What I know for sure is that this patch fix a dandling pointer. >> >> That's true. >> But I think we should have a better fix that does not ignore

Re: [Spice-devel] [PATCH] remove dandling pointer for RedCharDeviceVDIPort

2016-05-04 Thread Frediano Ziglio
> > On 05/03/2016 01:53 PM, Frediano Ziglio wrote: > >> > >> On 05/02/2016 11:25 AM, Frediano Ziglio wrote: > >>> This was caused by commit 1cec1c5118b65124de6bc6f984f376ff4e297bfb > >>> ("reds: Make VDIPortState a GObject") as the lifespan of RedCharDevice > >>> was changed. > >>> > >>> This coul

Re: [Spice-devel] [PATCH] remove dandling pointer for RedCharDeviceVDIPort

2016-05-03 Thread Uri Lublin
On 05/03/2016 01:53 PM, Frediano Ziglio wrote: On 05/02/2016 11:25 AM, Frediano Ziglio wrote: This was caused by commit 1cec1c5118b65124de6bc6f984f376ff4e297bfb ("reds: Make VDIPortState a GObject") as the lifespan of RedCharDevice was changed. This could be reproduced with: - start rhel7 mach

Re: [Spice-devel] [PATCH] remove dandling pointer for RedCharDeviceVDIPort

2016-05-03 Thread Frediano Ziglio
> > Hey, > > On Tue, May 03, 2016 at 06:53:49AM -0400, Frediano Ziglio wrote: > > > > Honestly more I look at the patch and this fix and more I think it's all > > a big bug... > > What I know for sure is that this patch fix a dandling pointer. > > NB: 'dangling' not 'dandling' (there is this ty

Re: [Spice-devel] [PATCH] remove dandling pointer for RedCharDeviceVDIPort

2016-05-03 Thread Christophe Fergeau
Hey, On Tue, May 03, 2016 at 06:53:49AM -0400, Frediano Ziglio wrote: > > Honestly more I look at the patch and this fix and more I think it's all > a big bug... > What I know for sure is that this patch fix a dandling pointer. NB: 'dangling' not 'dandling' (there is this typo in the short log,

Re: [Spice-devel] [PATCH] remove dandling pointer for RedCharDeviceVDIPort

2016-05-03 Thread Frediano Ziglio
> > On 05/02/2016 11:25 AM, Frediano Ziglio wrote: > > This was caused by commit 1cec1c5118b65124de6bc6f984f376ff4e297bfb > > ("reds: Make VDIPortState a GObject") as the lifespan of RedCharDevice > > was changed. > > > > This could be reproduced with: > > - start rhel7 machine > > - connect remot

Re: [Spice-devel] [PATCH] remove dandling pointer for RedCharDeviceVDIPort

2016-05-02 Thread Uri Lublin
On 05/02/2016 11:25 AM, Frediano Ziglio wrote: This was caused by commit 1cec1c5118b65124de6bc6f984f376ff4e297bfb ("reds: Make VDIPortState a GObject") as the lifespan of RedCharDevice was changed. This could be reproduced with: - start rhel7 machine - connect remote viewer (RV) - RV: login - co

[Spice-devel] [PATCH] remove dandling pointer for RedCharDeviceVDIPort

2016-05-02 Thread Frediano Ziglio
This was caused by commit 1cec1c5118b65124de6bc6f984f376ff4e297bfb ("reds: Make VDIPortState a GObject") as the lifespan of RedCharDevice was changed. This could be reproduced with: - start rhel7 machine - connect remote viewer (RV) - RV: login - connect ssh - SSH: stop agent - disconnect RV - SSH