Re: [Spice-devel] [PATCH] red_parse_qxl: fix throwing away drawables that have masks

2012-12-20 Thread Alon Levy
On Thu, Dec 13, 2012 at 08:29:48AM -0500, Yonit Halperin wrote: > On 12/13/2012 06:42 AM, Alon Levy wrote: > >All looks good except the assert. We should be removing them whenever they > >are guest trigerable - maybe I'm not following the code, but if in > >red_get_image sees no pallete in the qx

Re: [Spice-devel] [PATCH] red_parse_qxl: fix throwing away drawables that have masks

2012-12-13 Thread Yonit Halperin
On 12/13/2012 06:42 AM, Alon Levy wrote: All looks good except the assert. We should be removing them whenever they are guest trigerable - maybe I'm not following the code, but if in red_get_image sees no pallete in the qxl struct then palette will be NULL, which means it's guest trigerable.

Re: [Spice-devel] [PATCH] red_parse_qxl: fix throwing away drawables that have masks

2012-12-13 Thread Alon Levy
All looks good except the assert. We should be removing them whenever they are guest trigerable - maybe I'm not following the code, but if in red_get_image sees no pallete in the qxl struct then palette will be NULL, which means it's guest trigerable. > Non rgb bitmaps are allowed to not have a

[Spice-devel] [PATCH] red_parse_qxl: fix throwing away drawables that have masks

2012-12-12 Thread Yonit Halperin
Non rgb bitmaps are allowed to not have a palette in case they are masks (which are 1BIT bitmaps). Related: rhbz#864982 --- server/red_parse_qxl.c | 27 +-- server/red_worker.c|8 +++- 2 files changed, 16 insertions(+), 19 deletions(-) diff --git a/server/re