On 02/14/2012 11:24 AM, Gerd Hoffmann wrote:
Hi,
I can do it, by retrieving the surfaces addresses from the tracked guest
commands.
Exactly.
However, if we already do it, it would be even better if we
just dirty only the areas that are actually modified by the update_area
calls. The prob
Hi,
> I can do it, by retrieving the surfaces addresses from the tracked guest
> commands.
Exactly.
> However, if we already do it, it would be even better if we
> just dirty only the areas that are actually modified by the update_area
> calls. The problem is that (1) spice-server updates surf
On 02/14/2012 11:10 AM, Yonit Halperin wrote:
On 02/14/2012 10:35 AM, Gerd Hoffmann wrote:
On 02/14/12 09:10, Yonit Halperin wrote:
RHBZ #790083
Signed-off-by: Yonit Halperin
You are doing two things in one patch: (a) fix the compat mode bug,
which also matches the patch description, and (b)
On 02/14/2012 10:35 AM, Gerd Hoffmann wrote:
On 02/14/12 09:10, Yonit Halperin wrote:
RHBZ #790083
Signed-off-by: Yonit Halperin
You are doing two things in one patch: (a) fix the compat mode bug,
which also matches the patch description, and (b) skip vram when it is
unused (in compat mode).
On 02/14/12 09:10, Yonit Halperin wrote:
> RHBZ #790083
>
> Signed-off-by: Yonit Halperin
You are doing two things in one patch: (a) fix the compat mode bug,
which also matches the patch description, and (b) skip vram when it is
unused (in compat mode).
I'd love to see (b) done in a different
RHBZ #790083
Signed-off-by: Yonit Halperin
---
hw/qxl.c | 17 -
1 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index bc03c1d..a2a3380 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1478,14 +1478,21 @@ static void qxl_vm_change_state_handler(void *
Hi,
+qxl_set_dirty(devram_addr, devram_addr + qxl->vga.vram_size);
It is enougth to dirty the surface0 area.
Otherwise the patch looks fine.
cheers,
Gerd
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedes
---
hw/qxl.c |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 2bb36c6..9fdeffb 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1165,11 +1165,14 @@ static void qxl_vm_change_state_handler(void *opaque,
int running, int reason)
qemu_spice_vm_c