Re: [Spice-devel] [PATCH] plugin: try to run only /usr/libexec/spice-xpi-client

2011-06-28 Thread Alon Levy
On Tue, Jun 28, 2011 at 12:55:31AM +0200, Marc-André Lureau wrote: > Although not really important, the previous code was racy (stat + exec). > ACK. Just need to document that the spice-xpi-client must use exec as the last step, or be a symlink to the client itself. > I propose running /usr/libe

Re: [Spice-devel] [PATCH] plugin: try to run only /usr/libexec/spice-xpi-client

2011-06-28 Thread Marc-André Lureau
hi - Original Message - > On 06/28/2011 01:55 AM, Marc-André Lureau wrote: > > Although not really important, the previous code was racy (stat + > > exec). > > What seems to be the problem with it ? There is time between stat() and exec(), you can only reliably do exec() only. But well,

Re: [Spice-devel] [PATCH] plugin: try to run only /usr/libexec/spice-xpi-client

2011-06-28 Thread Uri Lublin
On 06/28/2011 01:55 AM, Marc-André Lureau wrote: Although not really important, the previous code was racy (stat + exec). What seems to be the problem with it ? I propose running /usr/libexec/spice-xpi-client without parameters, which could be a shell script with the required arguments to ca

[Spice-devel] [PATCH] plugin: try to run only /usr/libexec/spice-xpi-client

2011-06-27 Thread Marc-André Lureau
Although not really important, the previous code was racy (stat + exec). I propose running /usr/libexec/spice-xpi-client without parameters, which could be a shell script with the required arguments to call spicec or other spice clients (and could be easily tweaked to run various clients depending