Re: [Spice-devel] [PATCH] mjpeg_encoder: allocate "row" on demand

2011-07-13 Thread Christophe Fergeau
Hi, On Tue, Jul 12, 2011 at 07:46:33PM +0200, Andrea Celestino wrote: > Which version of libjpeg I should use? If I use libjpeg8, I receive this > compile error: > > >mjpeg_encoder.c:178:13: error: static declaration of 'jpeg_mem_dest' > follows non-static declaration > >/usr/include/jpeglib.h:95

Re: [Spice-devel] [PATCH] mjpeg_encoder: allocate "row" on demand

2011-07-13 Thread Christophe Fergeau
Hi, On Tue, Jul 12, 2011 at 07:46:33PM +0200, Andrea Celestino wrote: > Which version of libjpeg I should use? If I use libjpeg8, I receive this > compile error: > > >mjpeg_encoder.c:178:13: error: static declaration of 'jpeg_mem_dest' > follows non-static declaration > >/usr/include/jpeglib.h:95

Re: [Spice-devel] [PATCH] mjpeg_encoder: allocate "row" on demand

2011-07-12 Thread Andrea Celestino
Which version of libjpeg I should use? If I use libjpeg8, I receive this compile error: >mjpeg_encoder.c:178:13: error: static declaration of 'jpeg_mem_dest' follows non-static declaration >/usr/include/jpeglib.h:956:14: note: previous declaration of 'jpeg_mem_dest' was here Thanks. 2011/7/6 Ch

Re: [Spice-devel] [PATCH] mjpeg_encoder: allocate "row" on demand

2011-07-06 Thread Christophe Fergeau
On Wed, Jul 06, 2011 at 01:04:24PM +0200, Alon Levy wrote: > On Wed, Jul 06, 2011 at 12:32:53PM +0200, Christophe Fergeau wrote: > > It's not used when we use jpeg-turbo colorspaces, so it's better > > to allocate it when we know we'll need it rather than always > > allocating it even if it won't b

Re: [Spice-devel] [PATCH] mjpeg_encoder: allocate "row" on demand

2011-07-06 Thread Alon Levy
On Wed, Jul 06, 2011 at 12:32:53PM +0200, Christophe Fergeau wrote: > It's not used when we use jpeg-turbo colorspaces, so it's better > to allocate it when we know we'll need it rather than always > allocating it even if it won't be used. Just one thing - you're turning an abort to a return FALSE

[Spice-devel] [PATCH] mjpeg_encoder: allocate "row" on demand

2011-07-06 Thread Christophe Fergeau
It's not used when we use jpeg-turbo colorspaces, so it's better to allocate it when we know we'll need it rather than always allocating it even if it won't be used. --- server/mjpeg_encoder.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/server/mjpeg_enco