Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-15 Thread Christophe Fergeau
On Thu, Jun 14, 2012 at 06:49:28PM +0400, Michael Tokarev wrote: > And I'm about to give up, too, just disabling spice if spice guys > don't want it to be shipped in popular distributions. Well, at worst you have the option of shipping spice with a distro patch even if upstream disagrees with it w

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-15 Thread Alon Levy
On Fri, Jun 15, 2012 at 11:17:34AM +0200, Gerd Hoffmann wrote: > Hi, > > > From 44.1 you'd still need to externally resample to one of 8, 12, 16, 24, > > or 48k - but you can put any of those rates in, and take any of those out > > again without them needing to be the same. So only endpoints ac

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-15 Thread Gerd Hoffmann
Hi, > From 44.1 you'd still need to externally resample to one of 8, 12, 16, 24, > or 48k - but you can put any of those rates in, and take any of those out > again without them needing to be the same. So only endpoints actually > needing an 'oddball' rate would need a resampler to get them, th

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-15 Thread David Jaša
Ron píše v Pá 15. 06. 2012 v 16:29 +0930: > On Thu, Jun 14, 2012 at 01:58:55PM +0200, David Jaša wrote: > > Christophe Fergeau píše v Čt 14. 06. 2012 v 12:31 +0200: > > > On Thu, Jun 14, 2012 at 10:14:36AM +0200, Alexander Larsson wrote: > > > > However, that is imho a different issue than the celt

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-15 Thread Ron
On Thu, Jun 14, 2012 at 01:58:55PM +0200, David Jaša wrote: > Christophe Fergeau píše v Čt 14. 06. 2012 v 12:31 +0200: > > On Thu, Jun 14, 2012 at 10:14:36AM +0200, Alexander Larsson wrote: > > > However, that is imho a different issue than the celt051 support. A new > > > release of spice client a

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-14 Thread Ron
On Thu, Jun 14, 2012 at 08:55:59AM +0200, Gerd Hoffmann wrote: > Hi, > > >> I suspect there is no way around resampling support though. We'll need > >> it for compatibility reasons, so sound keeps working if only one side is > >> able to operate at 48 kHz. > > > > The ability to resample OTOH

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-14 Thread Michael Tokarev
14.06.2012 18:23, David Mansfield wrote: [] > As a user, being given the information and the option to disable is the best > case. A message saying "No compressed audio codec is available. Continuing > with audio enabled may degrade performance. Disable audio for this sesison?" I wonder which

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-14 Thread David Mansfield
On 06/14/2012 06:31 AM, Christophe Fergeau wrote: On Thu, Jun 14, 2012 at 10:14:36AM +0200, Alexander Larsson wrote: However, that is imho a different issue than the celt051 support. A new release of spice client and server supporting opus does not magically make old servers and client disappe

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-14 Thread David Jaša
Christophe Fergeau píše v Čt 14. 06. 2012 v 12:31 +0200: > On Thu, Jun 14, 2012 at 10:14:36AM +0200, Alexander Larsson wrote: > > However, that is imho a different issue than the celt051 support. A new > > release of spice client and server supporting opus does not magically > > make old servers an

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-14 Thread Gerd Hoffmann
Hi, > What I gather from this thread is that we don't want anyone to use the > fallback PCM code, which means we should deprecate it if that's really what > we want... Maybe the clients could be patched to stop advertising raw PCM > support? You can't, PCM is the baseline which isn't negotiated

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-14 Thread Christophe Fergeau
On Thu, Jun 14, 2012 at 12:50:39PM +0200, Alexander Larsson wrote: > On Thu, 2012-06-14 at 12:31 +0200, Christophe Fergeau wrote: > > What I gather from this thread is that we don't want anyone to use the > > fallback PCM code, which means we should deprecate it if that's really what > > we want...

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-14 Thread Alexander Larsson
On Thu, 2012-06-14 at 12:31 +0200, Christophe Fergeau wrote: > On Thu, Jun 14, 2012 at 10:14:36AM +0200, Alexander Larsson wrote: > > However, that is imho a different issue than the celt051 support. A new > > release of spice client and server supporting opus does not magically > > make old server

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-14 Thread Christophe Fergeau
On Thu, Jun 14, 2012 at 10:14:36AM +0200, Alexander Larsson wrote: > However, that is imho a different issue than the celt051 support. A new > release of spice client and server supporting opus does not magically > make old servers and client disappear, so it would still be the case > that e.g. deb

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-14 Thread Alexander Larsson
On Tue, 2012-06-12 at 16:33 +0200, Christophe Fergeau wrote: > On Tue, Jun 12, 2012 at 09:59:39AM -0400, Marc-André Lureau wrote: > > > > > > - Mensaje original - > > > On Tue, Jun 12, 2012 at 09:11:24AM -0400, Marc-André Lureau wrote: > > > > As long as the bitstream is not frozen, we ca

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-13 Thread Gerd Hoffmann
Hi, >> I suspect there is no way around resampling support though. We'll need >> it for compatibility reasons, so sound keeps working if only one side is >> able to operate at 48 kHz. > > The ability to resample OTOH probably isn't a silly thing to have, and > can be fairly easily set up as an

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-13 Thread Ron
On Wed, Jun 13, 2012 at 01:49:59PM +0200, Gerd Hoffmann wrote: > Hi, > > >> IMHO we should undust Alons opus patches *now* and get stuff ready. > >> Given the sample rate issue a bit more work that just switching the > >> codec, so it will need some time anyway. > > > > I replied to Ron private

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-13 Thread Gerd Hoffmann
Hi, >> IMHO we should undust Alons opus patches *now* and get stuff ready. >> Given the sample rate issue a bit more work that just switching the >> codec, so it will need some time anyway. > > I replied to Ron privately but let me repeat my problems last time > around. They are certainly not u

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-13 Thread Alon Levy
On Wed, Jun 13, 2012 at 09:51:24AM +0400, Michael Tokarev wrote: > On 13.06.2012 04:57, Brian Vetter wrote: > > As an outside observer with nothing really at stake here, it would seem > > that rather than Debian providing a hobbled version of the spice client > > that uses raw audio (disables Cel

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-13 Thread Alon Levy
On Wed, Jun 13, 2012 at 09:25:59AM +0200, Gerd Hoffmann wrote: > Hi, > > >> More official than the codec working group declaring it to be in its > >> finally frozen form, or the codec specification being submitted to and > >> approved by the IESG for publication? > > > > You keep refering to st

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-13 Thread Gerd Hoffmann
Hi, >> More official than the codec working group declaring it to be in its >> finally frozen form, or the codec specification being submitted to and >> approved by the IESG for publication? > > You keep refering to standards, while I am talking about what we can > actually rely on, the impleme

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Michael Tokarev
On 13.06.2012 04:57, Brian Vetter wrote: > As an outside observer with nothing really at stake here, it would seem that > rather than Debian providing a hobbled version of the spice client that uses > raw audio (disables Celt), they offer up a patch for both the server and the > client that impl

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Brian Vetter
As an outside observer with nothing really at stake here, it would seem that rather than Debian providing a hobbled version of the spice client that uses raw audio (disables Celt), they offer up a patch for both the server and the client that implements a negotiation for either Opus or Celt (for

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Ron
On Tue, Jun 12, 2012 at 09:38:37PM +0200, Marc-André Lureau wrote: > Hi > > On Tue, Jun 12, 2012 at 8:19 PM, Ron wrote: > > More official than the codec working group declaring it to be in its > > finally frozen form, or the codec specification being submitted to and > > approved by the IESG for

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Marc-André Lureau
Hi On Tue, Jun 12, 2012 at 8:19 PM, Ron wrote: > On Tue, Jun 12, 2012 at 06:30:36PM +0200, Marc-André Lureau wrote: >> Hi >> >> On Tue, Jun 12, 2012 at 5:35 PM, Ron wrote: >> > The bitstream has been frozen for just a tad under a year now. >> >> I don't know how you can claim that: http://www.op

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Ron
On Tue, Jun 12, 2012 at 06:30:36PM +0200, Marc-André Lureau wrote: > Hi > > On Tue, Jun 12, 2012 at 5:35 PM, Ron wrote: > > The bitstream has been frozen for just a tad under a year now. > > I don't know how you can claim that: http://www.opus-codec.org/downloads/ > > The bit-stream has not cha

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Marc-André Lureau
Hi On Tue, Jun 12, 2012 at 5:35 PM, Ron wrote: > The bitstream has been frozen for just a tad under a year now. I don't know how you can claim that: http://www.opus-codec.org/downloads/ The bit-stream has not changed, except for some corner cases that are unlikely to happen in the real world. [

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Alon Levy
On Wed, Jun 13, 2012 at 01:22:43AM +0930, Ron wrote: > > Hi Alon, > > On Tue, Jun 12, 2012 at 06:03:58PM +0300, Alon Levy wrote: > > On Tue, Jun 12, 2012 at 09:11:24AM -0400, Marc-André Lureau wrote: > > > Hi > > > > > > - Mensaje original - > > > > The ideal solution would be to have su

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Ron
Hi Alon, On Tue, Jun 12, 2012 at 06:03:58PM +0300, Alon Levy wrote: > On Tue, Jun 12, 2012 at 09:11:24AM -0400, Marc-André Lureau wrote: > > Hi > > > > - Mensaje original - > > > The ideal solution would be to have support for Opus, I think Marc > > > André > > > and Alon had started to

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Ron
Hi Marc-André, On Tue, Jun 12, 2012 at 09:59:39AM -0400, Marc-André Lureau wrote: > - Mensaje original - > > On Tue, Jun 12, 2012 at 09:11:24AM -0400, Marc-André Lureau wrote: > > > As long as the bitstream is not frozen, we can't use opus, or we > > > will > > > have the same problems as

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Christophe Fergeau
On Tue, Jun 12, 2012 at 10:55:48AM -0400, Marc-André Lureau wrote: > Can you quote the relevant part of the slide? See page 20 "Freeze bitstream format" with a check mark to its side Page 3 too "WGLC (Working Group Last Call) last minor bitstream changes" There are probably more details about this

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Alon Levy
On Tue, Jun 12, 2012 at 09:11:24AM -0400, Marc-André Lureau wrote: > Hi > > - Mensaje original - > > The ideal solution would be to have support for Opus, I think Marc > > André > > and Alon had started to look into that, but that's not done yet :( > > No, I didn't. Long time ago I propos

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Alon Levy
On Tue, Jun 12, 2012 at 09:11:24AM -0400, Marc-André Lureau wrote: > Hi > > - Mensaje original - > > The ideal solution would be to have support for Opus, I think Marc > > André > > and Alon had started to look into that, but that's not done yet :( > > No, I didn't. Long time ago I propos

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Marc-André Lureau
Hi - Mensaje original - > A guess supported by the slides at > http://www.opus-codec.org/presentations/ > , by various mailing posts from opus developers, ... > Can you quote the relevant part of the slide? According to http://www.opus-codec.org/downloads/ The bit-stream was tentativel

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Christophe Fergeau
On Tue, Jun 12, 2012 at 09:59:39AM -0400, Marc-André Lureau wrote: > > > - Mensaje original - > > On Tue, Jun 12, 2012 at 09:11:24AM -0400, Marc-André Lureau wrote: > > > As long as the bitstream is not frozen, we can't use opus, or we > > > will > > > have the same problems as with celt

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread David Mansfield
On 06/12/2012 09:11 AM, Marc-André Lureau wrote: Hi - Mensaje original - The ideal solution would be to have support for Opus, I think Marc André and Alon had started to look into that, but that's not done yet :( No, I didn't. Long time ago I proposed we have celt unstable flag, whic

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Marc-André Lureau
- Mensaje original - > On Tue, Jun 12, 2012 at 09:11:24AM -0400, Marc-André Lureau wrote: > > As long as the bitstream is not frozen, we can't use opus, or we > > will > > have the same problems as with celt today. > > As I understand it, while the bitstream is not officially frozen yet,

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Daniel P. Berrange
On Tue, Jun 12, 2012 at 09:11:24AM -0400, Marc-André Lureau wrote: > Hi > > - Mensaje original - > > The ideal solution would be to have support for Opus, I think Marc > > André > > and Alon had started to look into that, but that's not done yet :( > > No, I didn't. Long time ago I propos

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Christophe Fergeau
On Tue, Jun 12, 2012 at 09:11:24AM -0400, Marc-André Lureau wrote: > As long as the bitstream is not frozen, we can't use opus, or we will > have the same problems as with celt today. As I understand it, while the bitstream is not officially frozen yet, it's very unlikely to change before the real

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Marc-André Lureau
Hi - Mensaje original - > The ideal solution would be to have support for Opus, I think Marc > André > and Alon had started to look into that, but that's not done yet :( No, I didn't. Long time ago I proposed we have celt unstable flag, which would be completely broken in most cases but w

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Christophe Fergeau
On Tue, Jun 12, 2012 at 02:44:56PM +0400, Michael Tokarev wrote: > (Mind you, it wasn't me who decided that celt is somehow bad to > have in Debian, and I myself does not understand the issues 100%. > One of the issues, iirc, is that celt does not compile/work on > anything but x86). I think the m

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Marian Krcmarik
- Original Message - > From: "Daniel P. Berrange" > To: "Michael Tokarev" > Cc: spice-devel@lists.freedesktop.org, "Ron Lee" > Sent: Tuesday, June 12, 2012 1:52:48 PM > Subject: Re: [Spice-devel] [PATCH] make celt to be optional > >

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Daniel P. Berrange
On Tue, Jun 12, 2012 at 03:47:09PM +0400, Michael Tokarev wrote: > On 12.06.2012 15:35, Alexander Larsson wrote: > > Spice is very much about more than just pixels, that it does more than > > graphics (usb, sound, audio-video sync, clipboard, etc) is an important > > part of why Spice is better tha

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Michael Tokarev
On 12.06.2012 15:35, Alexander Larsson wrote: > On Tue, 2012-06-12 at 14:31 +0400, Michael Tokarev wrote: >> On 12.06.2012 13:15, Alexander Larsson wrote: >> [] >>> Its not incompatible, like I i said in my "(Well, .." part above. But >>> what it means is that it will send audio as PCM instead of c

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Alexander Larsson
On Tue, 2012-06-12 at 14:31 +0400, Michael Tokarev wrote: > On 12.06.2012 13:15, Alexander Larsson wrote: > [] > > Its not incompatible, like I i said in my "(Well, .." part above. But > > what it means is that it will send audio as PCM instead of compressing > > it. This is much larger, and will c

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Michael Tokarev
On 12.06.2012 14:27, Marc-André Lureau wrote: > On Mon, Jun 4, 2012 at 11:33 AM, Christophe Fergeau > wrote: >> Makes sense to me though I've only looked quickly through it. Since it >> works for you, I'm in favour of committing it if noone disagrees. > > I also don't like these changes to end u

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Michael Tokarev
On 12.06.2012 13:15, Alexander Larsson wrote: [] > Its not incompatible, like I i said in my "(Well, .." part above. But > what it means is that it will send audio as PCM instead of compressing > it. This is much larger, and will cause anyone using the debian spice > client to connect to a spice se

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Marc-André Lureau
On Mon, Jun 4, 2012 at 11:33 AM, Christophe Fergeau wrote: > Makes sense to me though I've only looked quickly through it. Since it > works for you, I'm in favour of committing it if noone disagrees. I also don't like these changes to end up upstream, for the same reasons Alex mentioned. It makes

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Alexander Larsson
On Tue, 2012-06-12 at 12:54 +0400, Michael Tokarev wrote: > On 12.06.2012 12:48, Alexander Larsson wrote: > > On Sat, 2012-06-02 at 15:46 +0400, Michael Tokarev wrote: > > > >> I plan to use this patch in the upcoming Debian > >> release, codename wheezy, to get rid of celt > >> codec library ther

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Michael Tokarev
On 12.06.2012 12:48, Alexander Larsson wrote: > On Sat, 2012-06-02 at 15:46 +0400, Michael Tokarev wrote: > >> I plan to use this patch in the upcoming Debian >> release, codename wheezy, to get rid of celt >> codec library there, since we decided celt051 is >> not going to be included, but it is

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Alexander Larsson
On Sat, 2012-06-02 at 15:46 +0400, Michael Tokarev wrote: > I plan to use this patch in the upcoming Debian > release, codename wheezy, to get rid of celt > codec library there, since we decided celt051 is > not going to be included, but it is obviously not > a good idea to drop spice entirely. I

[Spice-devel] [PATCH] Make celt to be optional

2012-06-11 Thread Liang Guo
Like patch [1] for spice, This patch will make celt to be optional for spice-gtk. [1] http://lists.freedesktop.org/archives/spice-devel/2012-June/009410.html Signed-off-by: Liang Guo --- configure.ac | 24 +++- gtk/channel-playback.c | 23 ++

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-04 Thread Michael Tokarev
On 04.06.2012 16:28, Alon Levy wrote: > On Mon, Jun 04, 2012 at 11:33:22AM +0200, Christophe Fergeau wrote: >> Makes sense to me though I've only looked quickly through it. Since it >> works for you, I'm in favour of committing it if noone disagrees. > > I agree. Would you do a review and ack? Pl

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-04 Thread Alon Levy
On Mon, Jun 04, 2012 at 11:33:22AM +0200, Christophe Fergeau wrote: > Makes sense to me though I've only looked quickly through it. Since it > works for you, I'm in favour of committing it if noone disagrees. I agree. Would you do a review and ack? > > Christophe > > On Sat, Jun 02, 2012 at 03:

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-04 Thread Christophe Fergeau
Makes sense to me though I've only looked quickly through it. Since it works for you, I'm in favour of committing it if noone disagrees. Christophe On Sat, Jun 02, 2012 at 03:46:55PM +0400, Michael Tokarev wrote: > With this patch applied, celt051 library isn't required > anymore. It is still re

[Spice-devel] [PATCH] make celt to be optional

2012-06-02 Thread Michael Tokarev
With this patch applied, celt051 library isn't required anymore. It is still required by default, but there's a new configure option, --disable-celt051, which makes the configure code to omit checking/finding the celt library and makes resulting spice library to not use celt codec at all. The cha