On 7/1/19 6:19 PM, Frediano Ziglio wrote:
Fedora 30 / gcc 9.1.1 20190503 (Red Hat 9.1.1-1) fails to build
because of this error/warning:
gstreamer-encoder.c: In function 'set_video_bit_rate':
gstreamer-encoder.c:518:17: error: taking the absolute value of unsigned
type 'uint64_t' {aka 'long un
>
> Fedora 30 / gcc 9.1.1 20190503 (Red Hat 9.1.1-1) fails to build
> because of this error/warning:
>
> > gstreamer-encoder.c: In function 'set_video_bit_rate':
> > gstreamer-encoder.c:518:17: error: taking the absolute value of unsigned
> > type 'uint64_t' {aka 'long unsigned int'} has no effec
Fedora 30 / gcc 9.1.1 20190503 (Red Hat 9.1.1-1) fails to build
because of this error/warning:
> gstreamer-encoder.c: In function 'set_video_bit_rate':
> gstreamer-encoder.c:518:17: error: taking the absolute value of unsigned type
> 'uint64_t' {aka 'long unsigned int'} has no effect [-Werror=abs
On Mon, Jul 1, 2019 at 2:29 PM Frediano Ziglio wrote:
>
> >
> > this warning is failing my build, I assume it comes from a new version
> > of the compiler catching the useless call to abs().
> >
>
> Yes, getting too with Fedora 30.
>
> Instead of "is failing my build" could you describe your envir
On Mon, Jul 1, 2019 at 2:33 PM Christophe de Dinechin
wrote:
>
>
> Kevin Pouget writes:
>
> > this warning is failing my build, I assume it comes from a new version
> > of the compiler catching the useless call to abs().
>
> Is it useless, or is there a signed/unsigned mismatch?
>
> I suspect the
Kevin Pouget writes:
> this warning is failing my build, I assume it comes from a new version
> of the compiler catching the useless call to abs().
Is it useless, or is there a signed/unsigned mismatch?
I suspect the intent is more something like:
abs((int64) (bit_rate - encoder->video_bit
>
> this warning is failing my build, I assume it comes from a new version
> of the compiler catching the useless call to abs().
>
Yes, getting too with Fedora 30.
Instead of "is failing my build" could you describe your environment?
Like "Compiling with gcc 13.4 under Fedora 34 "...
> ---
>
this warning is failing my build, I assume it comes from a new version
of the compiler catching the useless call to abs().
---
> error: taking the absolute value of unsigned type 'uint64_t'
> {aka 'long unsigned int'} has no effect [-Werror=absolute-value]
---
server/gstreamer-encoder.c | 2 +-
