Re: [Spice-devel] [PATCH] fixup! spicevmc: Change creation of RedCharDeviceSpiceVmc

2016-11-04 Thread Jonathon Jongsma
On Fri, 2016-11-04 at 13:34 -0400, Frediano Ziglio wrote: > > > > > > --- > > Possible fixup to Frediano's proposed patch. In general, GObject > > _new() > > functions should try not to do more than call g_object_new(). This > > is mostly > > to > > make things simpler for language bindings, but

Re: [Spice-devel] [PATCH] fixup! spicevmc: Change creation of RedCharDeviceSpiceVmc

2016-11-04 Thread Frediano Ziglio
> > --- > Possible fixup to Frediano's proposed patch. In general, GObject _new() > functions should try not to do more than call g_object_new(). This is mostly > to > make things simpler for language bindings, but I think it's good practice to > do > as much initialization via the GObject constru

[Spice-devel] [PATCH] fixup! spicevmc: Change creation of RedCharDeviceSpiceVmc

2016-11-04 Thread Jonathon Jongsma
--- Possible fixup to Frediano's proposed patch. In general, GObject _new() functions should try not to do more than call g_object_new(). This is mostly to make things simpler for language bindings, but I think it's good practice to do as much initialization via the GObject construction framework a