Re: [Spice-devel] [PATCH] fix tmp directory removal

2013-04-09 Thread Christophe Fergeau
On Tue, Apr 09, 2013 at 03:05:16PM +0200, Peter Hatina wrote: > of course, it is not. That's why I put there a rhbz link. We usually try to get bugs fixed upstream first, and then to backport that to the RHEL package, so having rhbz links in upstream commits against git master isn't unusual. If t

Re: [Spice-devel] [PATCH] fix tmp directory removal

2013-04-09 Thread Peter Hatina
Hi, of course, it is not. That's why I put there a rhbz link. On 04/09/2013 02:20 PM, Christophe Fergeau wrote: > On Tue, Apr 09, 2013 at 12:16:38PM +0200, Peter Hatina wrote: >> Hi, >> >> this should fix >> https://bugzilla.redhat.com/show_bug.cgi?id=882339 ^^ >> >> Are we ok with this short

Re: [Spice-devel] [PATCH] fix tmp directory removal

2013-04-09 Thread Christophe Fergeau
On Tue, Apr 09, 2013 at 12:16:38PM +0200, Peter Hatina wrote: > Hi, > > this should fix https://bugzilla.redhat.com/show_bug.cgi?id=882339 > > Are we ok with this short diff? This patch is not against git master if I'm not mistaken (the unlink() are no longer there, nor the ControllerWaitHelper

Re: [Spice-devel] [PATCH] fix tmp directory removal

2013-04-09 Thread Hans de Goede
Looks good, ack. On 04/09/2013 12:16 PM, Peter Hatina wrote: Hi, this should fix https://bugzilla.redhat.com/show_bug.cgi?id=882339 Are we ok with this short diff? --- SpiceXPI/src/plugin/plugin.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/SpiceXPI/src/plugin/plugin.cpp b/Spic

[Spice-devel] [PATCH] fix tmp directory removal

2013-04-09 Thread Peter Hatina
Hi, this should fix https://bugzilla.redhat.com/show_bug.cgi?id=882339 Are we ok with this short diff? --- SpiceXPI/src/plugin/plugin.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/SpiceXPI/src/plugin/plugin.cpp b/SpiceXPI/src/plugin/plugin.cpp index 4a88e45..d5ca720 100644 --- a/Spi