Re: [Spice-devel] [PATCH] fix 16 bpp LZ image decompression

2016-04-18 Thread Frediano Ziglio
> > On Čt, 2016-04-14 at 17:56 +0100, Frediano Ziglio wrote: > > LZ image decompression was broken for 16 bpp: > > - stride was computed not computed correctly (as width*4). This caused > > IMO one extra 'computed' here. > Yes, Jonathon reported the same issue but unfortunately patch was alread

Re: [Spice-devel] [PATCH] fix 16 bpp LZ image decompression

2016-04-18 Thread David Jaša
On Čt, 2016-04-14 at 17:56 +0100, Frediano Ziglio wrote: > LZ image decompression was broken for 16 bpp: > - stride was computed not computed correctly (as width*4). This caused IMO one extra 'computed' here. > also a buffer underflow; > - stride in pixman is always multiple of 4 bytes (so for

Re: [Spice-devel] [PATCH] fix 16 bpp LZ image decompression

2016-04-15 Thread Jonathon Jongsma
On Thu, 2016-04-14 at 17:56 +0100, Frediano Ziglio wrote: > LZ image decompression was broken for 16 bpp: > - stride was computed not computed correctly (as width*4). This caused > also a buffer underflow; FYI: extra "computed" here. Remove the first one. > - stride in pixman is always multipl

Re: [Spice-devel] [PATCH] fix 16 bpp LZ image decompression

2016-04-15 Thread Pavel Grunt
Hi, On Thu, 2016-04-14 at 17:56 +0100, Frediano Ziglio wrote: > LZ image decompression was broken for 16 bpp: > - stride was computed not computed correctly (as width*4). This > caused >   also a buffer underflow; > - stride in pixman is always multiple of 4 bytes (so for 16 bpp is >   ALIGN(width

[Spice-devel] [PATCH] fix 16 bpp LZ image decompression

2016-04-14 Thread Frediano Ziglio
LZ image decompression was broken for 16 bpp: - stride was computed not computed correctly (as width*4). This caused also a buffer underflow; - stride in pixman is always multiple of 4 bytes (so for 16 bpp is ALIGN(width*2, 4)) so image decompressed by lz_decode as some missing bytes to be fi