Re: [Spice-devel] [PATCH] drm/qxl: get vga ioports

2019-08-05 Thread Gerd Hoffmann
Hi, > > + ret = vga_get_interruptible(pdev, VGA_RSRC_LEGACY_IO); > > + if (ret) { > > + DRM_ERROR("can't get legacy vga ports\n"); > > + goto put_vga; > > I suppose that if this fails it's secondary so should continue. Ah, right, there are secondary qxl cards (without t

Re: [Spice-devel] [PATCH] drm/qxl: get vga ioports

2019-08-05 Thread Frediano Ziglio
> > qxl has two modes: "native" (used by the drm driver) and "vga" (vga > compatibility mode, typically used for boot display and firmware > framebuffers). > > Accessing any vga ioport will switch the qxl device into vga mode. > The qxl driver never does that, but other drivers accessing vga port

[Spice-devel] [PATCH] drm/qxl: get vga ioports

2019-08-05 Thread Gerd Hoffmann
qxl has two modes: "native" (used by the drm driver) and "vga" (vga compatibility mode, typically used for boot display and firmware framebuffers). Accessing any vga ioport will switch the qxl device into vga mode. The qxl driver never does that, but other drivers accessing vga ports can trigger t