Re: [Spice-devel] [PATCH] drm/qxl: add drm_driver.release callback.

2020-02-07 Thread Thomas Zimmermann
Hi Am 07.02.20 um 13:14 schrieb Gerd Hoffmann: > Move final cleanups to qxl_drm_release() callback. > Add drm_atomic_helper_shutdown() call to qxl_pci_remove(). > > Reorder calls in qxl_device_fini(). Cleaning up gem & ttm > might trigger qxl commands, so we should do that before > releaseing co

Re: [Spice-devel] [PATCH] drm/qxl: add drm_driver.release callback.

2020-02-07 Thread Daniel Vetter
On Fri, Feb 07, 2020 at 01:14:05PM +0100, Gerd Hoffmann wrote: > Move final cleanups to qxl_drm_release() callback. > Add drm_atomic_helper_shutdown() call to qxl_pci_remove(). > > Reorder calls in qxl_device_fini(). Cleaning up gem & ttm > might trigger qxl commands, so we should do that before

[Spice-devel] [PATCH] drm/qxl: add drm_driver.release callback.

2020-02-07 Thread Gerd Hoffmann
Move final cleanups to qxl_drm_release() callback. Add drm_atomic_helper_shutdown() call to qxl_pci_remove(). Reorder calls in qxl_device_fini(). Cleaning up gem & ttm might trigger qxl commands, so we should do that before releaseing command rings. Signed-off-by: Gerd Hoffmann --- drivers/gpu