Re: [Spice-devel] [PATCH] cursor: fix wrong logic when initializing the channel

2015-11-04 Thread Frediano Ziglio
> > On Wed, Nov 4, 2015 at 11:54 AM, Frediano Ziglio wrote: > >> > >> It's a regression introduced by commit e601e920bd5. The logic error was > >> introduced when trying to achieve the following code[0]. but rewritten > >> to prefer an early return. > >> > >> [0]: > >> if (cursor_is_connected(wor

Re: [Spice-devel] [PATCH] cursor: fix wrong logic when initializing the channel

2015-11-04 Thread Fabiano FidĂȘncio
On Wed, Nov 4, 2015 at 11:54 AM, Frediano Ziglio wrote: >> >> It's a regression introduced by commit e601e920bd5. The logic error was >> introduced when trying to achieve the following code[0]. but rewritten >> to prefer an early return. >> >> [0]: >> if (cursor_is_connected(worker) >> && !COM

Re: [Spice-devel] [PATCH] cursor: fix wrong logic when initializing the channel

2015-11-04 Thread Frediano Ziglio
> > It's a regression introduced by commit e601e920bd5. The logic error was > introduced when trying to achieve the following code[0]. but rewritten > to prefer an early return. > > [0]: > if (cursor_is_connected(worker) > && !COMMON_CHANNEL(worker->cursor_channel)->during_target_migrate) { >

[Spice-devel] [PATCH] cursor: fix wrong logic when initializing the channel

2015-11-04 Thread Fabiano FidĂȘncio
It's a regression introduced by commit e601e920bd5. The logic error was introduced when trying to achieve the following code[0]. but rewritten to prefer an early return. [0]: if (cursor_is_connected(worker) && !COMMON_CHANNEL(worker->cursor_channel)->during_target_migrate) { red_channe