Hi,
There still is quite some work to do, but I think that this can be
committed as is, and then build from there. I believe fixing up things
incrementally is better then doing one monster patch. So ack.
Note I'm working on this now, I will post set of patches on top of this
one before sunday.
Hi,
The grab command is being changed so that it takes an array of types
rather then a single type,
Ah, ok, so we will pass a list not a single type.
That answers my question already ;)
VD_AGENT_CLIPBOARD_UTF8_TEXT
VD_AGENT_CLIPBOARD_HTML
Good.
cheers,
Gerd
__
Hi,
On 09/30/2010 11:20 AM, Gerd Hoffmann wrote:
Hi,
not done yet:
-clipboards formats are still uint32_t, not mime types stores as strings
What is the plan for multiple formats? When copying something in firefox it
provides both UTF8_STRING and text/html (and a few others too).
When so
Hi,
not done yet:
-clipboards formats are still uint32_t, not mime types stores as strings
What is the plan for multiple formats? When copying something in
firefox it provides both UTF8_STRING and text/html (and a few others too).
cheers,
Gerd
_
On Wed, 2010-09-29 at 14:17 +0200, Arnon Gilboa wrote:
> -enable USE_XRANDR_1_2
I'm commiting this right away so we get it for 0.6.1.
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-dev
-includes most of Hans' review fixes (up to the SelectionRequest comment [4]) &
X11 wips sent by Hans (10x!)
-use the VD_AGENT_CLIPBOARD_* types in the platform code
-add ifs for VD_AGENT_CAP_CLIPBOARD_BY_DEMAND in both sides
-support the GRAB/REQUEST/DATA/RELEASE verbs in both ways
-pasting clipb
Hi,
On 09/27/2010 04:51 PM, Arnon Gilboa wrote:
Hans de Goede wrote:
Hi,
On a second review I've found some more issues with the X11 client
copy paste code, note some of this were already present before
the patch in question.
1) You're using the XA_PRIMARY selection, this is the one which
ge
Hans de Goede wrote:
Hi,
On a second review I've found some more issues with the X11 client
copy paste code, note some of this were already present before
the patch in question.
1) You're using the XA_PRIMARY selection, this is the one which
gets set as soon as you select anything with the
Hans de Goede wrote:
2) I believe we should not add bitmap support until we've a
platform independent way of doing this. Adding features prematurely
only leads to troubles down the road later (see the defunct before
even really used old clipboard capability flag for example).
will be removed u
Hi,
On a second review I've found some more issues with the X11 client
copy paste code, note some of this were already present before
the patch in question.
1) You're using the XA_PRIMARY selection, this is the one which
gets set as soon as you select anything with the mouse cursor,
no nee
Hi,
On 09/26/2010 11:28 AM, Arnon Gilboa wrote:
1) I see no need for platform.h to contain a duplicate
enum with vd_agent.h we should simply use the
VD_AGENT_CLIPBOARD_* types in the platform
code too, this way we can get rid of this enum,
the ClipboardType type, the clipboard_types
array an
Hi,
On 09/26/2010 10:34 AM, Arnon Gilboa wrote:
Alexander Larsson wrote:
On Wed, 2010-09-22 at 14:16 +0200, Arnon Gilboa wrote:
utf8_atom = XInternAtom(x_display, "UTF8_STRING", False);
+
+ Platform::clipboard_formats[0].format = utf8_atom;
+ Platform::clipboard_formats[0].type =
Platform::CLI
Right, Thanks Hans!
Hans de Goede wrote:
Hi,
I've applied this patch to my local git repo to be able to work
on copy and paste support in the Linux agent, and it needs the following
patch on top to compile the linux client successfully:
diff --git a/client/x11/Makefile.am b/client/x11/Makefile
Alexander Larsson wrote:
On Wed, 2010-09-22 at 14:16 +0200, Arnon Gilboa wrote:
utf8_atom = XInternAtom(x_display, "UTF8_STRING", False);
+
+Platform::clipboard_formats[0].format = utf8_atom;
+Platform::clipboard_formats[0].type =
Platform::CLIPBOARD_UTF8_TEXT;
How common
Hi,
I've applied this patch to my local git repo to be able to work
on copy and paste support in the Linux agent, and it needs the following
patch on top to compile the linux client successfully:
diff --git a/client/x11/Makefile.am b/client/x11/Makefile.am
index 2a83473..f570a10 100644
--- a/cli
Hi,
See comments inline.
On 09/22/2010 02:16 PM, Arnon Gilboa wrote:
-support the GRAB/REQUEST/DATA/RELEASE verbs in both ways
-pasting clipboard data is now "only-by-demand" from both sides (client and
agent), whose behavior is symmetric
-client and agent don't read or send the contents of th
On Wed, 2010-09-22 at 14:16 +0200, Arnon Gilboa wrote:
>
> utf8_atom = XInternAtom(x_display, "UTF8_STRING", False);
> +
> +Platform::clipboard_formats[0].format = utf8_atom;
> +Platform::clipboard_formats[0].type =
> Platform::CLIPBOARD_UTF8_TEXT;
How common is UTF8_STRING support t
-support the GRAB/REQUEST/DATA/RELEASE verbs in both ways
-pasting clipboard data is now "only-by-demand" from both sides (client and
agent), whose behavior is symmetric
-client and agent don't read or send the contents of the clipboard
unnecessarily (e.g. copy, internal paste, repeating paste, f
18 matches
Mail list logo