Re: [Spice-devel] [PATCH] catch: directory is now catch2

2019-01-30 Thread Frediano Ziglio
> > On 1/29/19 5:53 PM, Frediano Ziglio wrote: > >> Upstream and since Fedora 27 > >> > >> Signed-off-by: Uri Lublin > > > > Does it work on RHEL7 ? > > Only if RHEL-7 has catch2. > If not see another option below. > It sounds reasonable then. Newer catch sources uses catch2 directory (tried

Re: [Spice-devel] [PATCH] catch: directory is now catch2

2019-01-30 Thread Uri Lublin
On 1/29/19 5:53 PM, Frediano Ziglio wrote: Upstream and since Fedora 27 Signed-off-by: Uri Lublin Does it work on RHEL7 ? Only if RHEL-7 has catch2. If not see another option below. --- Another option is to check both catch/ and catch2/ and pick the one that is installed on the system,

Re: [Spice-devel] [PATCH] catch: directory is now catch2

2019-01-30 Thread Frediano Ziglio
> On 1/30/19 10:48 AM, Christophe Fergeau wrote: > > On Tue, Jan 29, 2019 at 05:51:54PM +0200, Uri Lublin wrote: > >> Upstream and since Fedora 27 > >> > >> Signed-off-by: Uri Lublin > >> --- > >> > >> Another option is to check both catch/ and catch2/ > >> and pick the one that is installed on th

Re: [Spice-devel] [PATCH] catch: directory is now catch2

2019-01-30 Thread Uri Lublin
On 1/30/19 10:48 AM, Christophe Fergeau wrote: On Tue, Jan 29, 2019 at 05:51:54PM +0200, Uri Lublin wrote: Upstream and since Fedora 27 Signed-off-by: Uri Lublin --- Another option is to check both catch/ and catch2/ and pick the one that is installed on the system, if any --- configure.ac

Re: [Spice-devel] [PATCH] catch: directory is now catch2

2019-01-30 Thread Frediano Ziglio
> > On Tue, Jan 29, 2019 at 05:51:54PM +0200, Uri Lublin wrote: > > Upstream and since Fedora 27 > > > > Signed-off-by: Uri Lublin > > --- > > > > Another option is to check both catch/ and catch2/ > > and pick the one that is installed on the system, if any > > > > --- > > configure.ac

Re: [Spice-devel] [PATCH] catch: directory is now catch2

2019-01-30 Thread Christophe Fergeau
On Tue, Jan 29, 2019 at 05:51:54PM +0200, Uri Lublin wrote: > Upstream and since Fedora 27 > > Signed-off-by: Uri Lublin > --- > > Another option is to check both catch/ and catch2/ > and pick the one that is installed on the system, if any > > --- > configure.ac | 4 +

Re: [Spice-devel] [PATCH] catch: directory is now catch2

2019-01-29 Thread Frediano Ziglio
> Upstream and since Fedora 27 > > Signed-off-by: Uri Lublin Does it work on RHEL7 ? > --- > > Another option is to check both catch/ and catch2/ > and pick the one that is installed on the system, if any > > --- > configure.ac | 4 ++-- > src/unittests/test-mjpeg-fa

[Spice-devel] [PATCH] catch: directory is now catch2

2019-01-29 Thread Uri Lublin
Upstream and since Fedora 27 Signed-off-by: Uri Lublin --- Another option is to check both catch/ and catch2/ and pick the one that is installed on the system, if any --- configure.ac | 4 ++-- src/unittests/test-mjpeg-fallback.cpp | 2 +- src/unittests/test-stream-por