Re: [Spice-devel] [PATCH] Use RedCharDevice instead of SpiceCharDeviceState

2016-03-31 Thread Jonathon Jongsma
On Thu, 2016-03-31 at 03:12 -0400, Frediano Ziglio wrote: > > > > Hi Jonathon, > > > > On Wed, Mar 30, 2016 at 05:17:47PM -0500, Jonathon Jongsma wrote: > > > These two type names are typedefs of eachother, but it's confusing to > > > have two different typenames for the same type throughout the

Re: [Spice-devel] [PATCH] Use RedCharDevice instead of SpiceCharDeviceState

2016-03-31 Thread Christophe Fergeau
On Thu, Mar 31, 2016 at 03:12:44AM -0400, Frediano Ziglio wrote: > > > > Hi Jonathon, > > > > On Wed, Mar 30, 2016 at 05:17:47PM -0500, Jonathon Jongsma wrote: > > > These two type names are typedefs of eachother, but it's confusing to > > > have two different typenames for the same type througho

Re: [Spice-devel] [PATCH] Use RedCharDevice instead of SpiceCharDeviceState

2016-03-31 Thread Victor Toso
Hi, On Thu, Mar 31, 2016 at 03:12:44AM -0400, Frediano Ziglio wrote: > > > > Hi Jonathon, > > > > On Wed, Mar 30, 2016 at 05:17:47PM -0500, Jonathon Jongsma wrote: > > > These two type names are typedefs of eachother, but it's confusing to > > > have two different typenames for the same type thro

Re: [Spice-devel] [PATCH] Use RedCharDevice instead of SpiceCharDeviceState

2016-03-31 Thread Frediano Ziglio
> > These two type names are typedefs of eachother, but it's confusing to > have two different typenames for the same type throughout the code. > Convert everythign to use RedCharDevice. > --- > > This patch should apply to the end of this patch series. Comments? > Patch is good but should appl

Re: [Spice-devel] [PATCH] Use RedCharDevice instead of SpiceCharDeviceState

2016-03-31 Thread Frediano Ziglio
> > Hi Jonathon, > > On Wed, Mar 30, 2016 at 05:17:47PM -0500, Jonathon Jongsma wrote: > > These two type names are typedefs of eachother, but it's confusing to > > have two different typenames for the same type throughout the code. > > Convert everythign to use RedCharDevice. > > I agree with y

Re: [Spice-devel] [PATCH] Use RedCharDevice instead of SpiceCharDeviceState

2016-03-30 Thread Victor Toso
Hi Jonathon, On Wed, Mar 30, 2016 at 05:17:47PM -0500, Jonathon Jongsma wrote: > These two type names are typedefs of eachother, but it's confusing to > have two different typenames for the same type throughout the code. > Convert everythign to use RedCharDevice. I agree with you about this. > -

[Spice-devel] [PATCH] Use RedCharDevice instead of SpiceCharDeviceState

2016-03-30 Thread Jonathon Jongsma
These two type names are typedefs of eachother, but it's confusing to have two different typenames for the same type throughout the code. Convert everythign to use RedCharDevice. --- This patch should apply to the end of this patch series. Comments? server/char-device.c | 238 +