Re: [Spice-devel] [PATCH] Use GByteArray to implement RedsClientMonitorsConfig

2013-10-08 Thread Christophe Fergeau
On Tue, Oct 08, 2013 at 07:03:20AM -0400, Marc-André Lureau wrote: > > - Original Message - > > reds_on_main_agent_monitor_config() is manually implementing > > a grow-on-append char *. glib's GByteArray can do this for us, > > using it makes the code simpler to read. > > Also I don't cle

Re: [Spice-devel] [PATCH] Use GByteArray to implement RedsClientMonitorsConfig

2013-10-08 Thread Marc-André Lureau
- Original Message - > reds_on_main_agent_monitor_config() is manually implementing > a grow-on-append char *. glib's GByteArray can do this for us, > using it makes the code simpler to read. Given that we don't have test suite, I am not really for such small cleanup changes. Also I don'

[Spice-devel] [PATCH] Use GByteArray to implement RedsClientMonitorsConfig

2013-10-08 Thread Christophe Fergeau
reds_on_main_agent_monitor_config() is manually implementing a grow-on-append char *. glib's GByteArray can do this for us, using it makes the code simpler to read. --- server/reds-private.h | 4 +--- server/reds.c | 27 +-- 2 files changed, 14 insertions(+), 17 de