Re: [Spice-devel] [PATCH] Removed some not necessary headers inclusions

2016-09-14 Thread Frediano Ziglio
> > Hi Frediano, > > what is the rule ? I prefer to include header if some of its > declarations is used. > It's quite minimal include. > e.g.: i see that you removed >  #include > from inputs-channel.h but VDAgentMouseState is used in the file > Actually this hunk was in a separate patch w

Re: [Spice-devel] [PATCH] Removed some not necessary headers inclusions

2016-09-14 Thread Pavel Grunt
Hi Frediano, what is the rule ? I prefer to include header if some of its declarations is used. e.g.: i see that you removed  #include from inputs-channel.h but VDAgentMouseState is used in the file Thanks, Pavel On Wed, 2016-09-14 at 11:46 +0100, Frediano Ziglio wrote: > Signed-off-by: Fredia

[Spice-devel] [PATCH] Removed some not necessary headers inclusions

2016-09-14 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/display-channel.h | 7 +-- server/inputs-channel.h | 1 - server/main-dispatcher.h | 1 - server/red-channel.h | 1 - server/red-parse-qxl.h | 1 - server/red-record-qxl.h | 1 - 6 files changed, 1 insertion(+), 11 deletions(-) diff --git a/s