On Mon, Oct 7, 2013 at 10:02 AM, Christophe Fergeau wrote:
> Hey,
>
> Patch looks good, a few comments:
> - handle_dev_loadvm_commands() would have the same surface_cmd leak
> except that it does not check red_get_surface_cmd() return value,
> probably a bug as well
I just sent another patch
On Fri, Oct 04, 2013 at 08:59:55PM +0200, Marc-André Lureau wrote:
> diff --git a/spice-common b/spice-common
> index e443c9f..7e8ba10 16
> --- a/spice-common
> +++ b/spice-common
> @@ -1 +1 @@
> -Subproject commit e443c9f6039407633d38a0eba03c344272ac8559
> +Subproject commit 7e8ba10779a3fb11d5
Hey,
Patch looks good, a few comments:
- handle_dev_loadvm_commands() would have the same surface_cmd leak
except that it does not check red_get_surface_cmd() return value,
probably a bug as well
- things would be slightly nicer if
red_get_surface_cmd()/red_get_cursor_cmd() returned a newly
Plug what looks like memory leaks, that could be potentially be
triggered by a misbehaving guest.
---
server/red_worker.c | 9 +++--
spice-common| 2 +-
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index f5a5553..8f7a1fc 10064
