Re: [Spice-devel] [PATCH] Fix = use instead of ==

2012-02-23 Thread Arnon Gilboa
Ack & thanks. The flow seems much better now;) will be tested for regression anyway. Christophe Fergeau wrote: When checking for ConnectNamedPipe status, the error check uses if ( err = ERROR_IO_PENDING) instead of using == which causes this error check to always trigger. This commit fixes this

Re: [Spice-devel] [PATCH] Fix = use instead of ==

2012-02-20 Thread Alon Levy
On Mon, Feb 20, 2012 at 11:53:14AM +0100, Christophe Fergeau wrote: > When checking for ConnectNamedPipe status, the error check uses > if ( err = ERROR_IO_PENDING) instead of using == which causes this > error check to always trigger. This commit fixes this, however it > needs careful testing sinc

[Spice-devel] [PATCH] Fix = use instead of ==

2012-02-20 Thread Christophe Fergeau
When checking for ConnectNamedPipe status, the error check uses if ( err = ERROR_IO_PENDING) instead of using == which causes this error check to always trigger. This commit fixes this, however it needs careful testing since the fact that it went unnoticed means the code with the bug was working as