Looks good to me,
ACK.
- Original Message -
> This fixes a bug with x-spice where you could not specify
> a default mode in an xorg.conf modeline that was greater
> than 1024x768. This also eliminates (and partially
> reverts) patch c1b537fc.
>
> It also fixes bug 894421, where gnome mo
This fixes a bug with x-spice where you could not specify
a default mode in an xorg.conf modeline that was greater
than 1024x768. This also eliminates (and partially
reverts) patch c1b537fc.
It also fixes bug 894421, where gnome modes flicker
and work poorly.
Signed-off-by: Jeremy White
---
sr
> I've attached my current 'best' patch if others are interested. I'll
> try to follow through tomorrow or Monday.
Attached is my current best effort. This version solves my problem for
x-spice, and seems to be as good as my previous efforts on qemu/qxl with
4 heads.I'm feeling that I have m
> I have one bit of due diligence I'm going to do as well;
> (I wanted to make sure the change to qxl_resize_primary_to_virtual
> shouldn't be it's own patch, and maybe see if that's what
> led to my NumHeads confusion), but I'll hopefully respin
> and submit today or tomorrow.
Blech. I'm glad I
On 01/24/2013 05:37 AM, Hans de Goede wrote:
Hi,
Overall comments:
1) I've run several tests with this, and this looks good to go.
Great, thanks!
2) As Alon said, please split of the #if 0 blocks removal, I agree they can
be removed after this patch, but lets do so in a follow-up patch
Se
Is it possible to break out the #if 0 removals since I don't see any
relation between them and this patch?
I'm a huge fan of smaller, more surgical patches.
And yeah, I'll shift the first #if 0 removal to another patch.
But I think the larger and more material #if 0 removals are
related to th
Hi,
Overall comments:
1) I've run several tests with this, and this looks good to go.
2) As Alon said, please split of the #if 0 blocks removal, I agree they can
be removed after this patch, but lets do so in a follow-up patch
3) I don't like the hardcoded 1024x768, yes I know it was there befor
On Wed, Jan 23, 2013 at 04:40:38PM -0600, Jeremy White wrote:
> This fixes a bug with x-spice where you could not specify
> a default mode in an xorg.conf modeline that was greater
> than 1024x768. This also eliminates (and partially
> reverts) patch c1b537fc.
>
> It may also fix bug 894421, wher
This fixes a bug with x-spice where you could not specify
a default mode in an xorg.conf modeline that was greater
than 1024x768. This also eliminates (and partially
reverts) patch c1b537fc.
It may also fix bug 894421, where gnome modes flicker
and work poorly.
Signed-off-by: Jeremy White
---
