Re: [Spice-devel] [PATCH] Do not use static buffer to avoid possible races

2018-08-17 Thread Christophe Fergeau
Good catch, and the buffer is small enough that it's not a big deal if it's not static, and the data it contains is copied in this same block, so we don't need the buffer to stay alive for a prolonged time. Acked-by: Christophe Fergeau On Tue, Aug 14, 2018 at 10:35:56AM +0100, Frediano Ziglio w

[Spice-devel] [PATCH] Do not use static buffer to avoid possible races

2018-08-14 Thread Frediano Ziglio
Using a static writeable buffer and threads could lead to race conditions (like multiple threads calling the same function). The fci_template buffer is changed some lines below with a memcpy. Signed-off-by: Frediano Ziglio --- src/card_7816.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)