Re: [Spice-devel] [PATCH] Disable IME to allow receiving all keys

2016-04-20 Thread Takao Fujiwara
On 04/20/16 23:29, Frediano Ziglio-san wrote: My understanding is, Virt-Viewer with ImmDisableIME(-1) can send key events even if the title bar is focused when IME is enabled. I attached the screenshot of the problem when ImmDisableIME(-1) is not applied. https://bugzilla.redhat.com/show_bug.cgi

Re: [Spice-devel] [PATCH] Disable IME to allow receiving all keys

2016-04-20 Thread Frediano Ziglio
> > My understanding is, Virt-Viewer with ImmDisableIME(-1) can send key events > even if the title bar is focused when IME is enabled. > I attached the screenshot of the problem when ImmDisableIME(-1) is not > applied. > https://bugzilla.redhat.com/show_bug.cgi?id=1311858#c42 > > But spice-gtk c

Re: [Spice-devel] [PATCH] Disable IME to allow receiving all keys

2016-04-20 Thread Takao Fujiwara
My understanding is, Virt-Viewer with ImmDisableIME(-1) can send key events even if the title bar is focused when IME is enabled. I attached the screenshot of the problem when ImmDisableIME(-1) is not applied. https://bugzilla.redhat.com/show_bug.cgi?id=1311858#c42 But spice-gtk can receives all

Re: [Spice-devel] [PATCH] Disable IME to allow receiving all keys

2016-04-19 Thread Fabiano Fidêncio
On Tue, Apr 19, 2016 at 4:11 PM, Fabiano Fidêncio wrote: > On Tue, Apr 19, 2016 at 4:00 PM, Frediano Ziglio wrote: >>> >>> On Tue, Apr 19, 2016 at 3:28 PM, Pavel Grunt wrote: >>> > Ack, I am going to push it. >>> >>> Do we really need this patch upstream? >>> It's a half-solution, at most, that

Re: [Spice-devel] [PATCH] Disable IME to allow receiving all keys

2016-04-19 Thread Fabiano Fidêncio
On Tue, Apr 19, 2016 at 4:00 PM, Frediano Ziglio wrote: >> >> On Tue, Apr 19, 2016 at 3:28 PM, Pavel Grunt wrote: >> > Ack, I am going to push it. >> >> Do we really need this patch upstream? >> It's a half-solution, at most, that doesn't work on newer Windows. >> > > Are you referring to Window

Re: [Spice-devel] [PATCH] Disable IME to allow receiving all keys

2016-04-19 Thread Frediano Ziglio
> > On Tue, Apr 19, 2016 at 3:28 PM, Pavel Grunt wrote: > > Ack, I am going to push it. > > Do we really need this patch upstream? > It's a half-solution, at most, that doesn't work on newer Windows. > Are you referring to Window 11? It works on Windows 10. Frediano > Also, a better commit m

Re: [Spice-devel] [PATCH] Disable IME to allow receiving all keys

2016-04-19 Thread Fabiano Fidêncio
On Tue, Apr 19, 2016 at 3:28 PM, Pavel Grunt wrote: > Ack, I am going to push it. Do we really need this patch upstream? It's a half-solution, at most, that doesn't work on newer Windows. Also, a better commit message would be more than appreciated in case we really decide to have it upstream.

Re: [Spice-devel] [PATCH] Disable IME to allow receiving all keys

2016-04-19 Thread Pavel Grunt
Ack, I am going to push it. Thanks, Pavel On Mon, 2016-04-18 at 14:55 +0100, Frediano Ziglio wrote: > From: Christophe Fergeau > > This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1297640 > > Acked-by: Frediano Ziglio > --- >  src/virt-viewer-util.c | 7 +++ >  1 file changed, 7 inse

[Spice-devel] [PATCH] Disable IME to allow receiving all keys

2016-04-18 Thread Frediano Ziglio
From: Christophe Fergeau This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1297640 Acked-by: Frediano Ziglio --- src/virt-viewer-util.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/virt-viewer-util.c b/src/virt-viewer-util.c index 279f9a5..8cf52ec 100644 --- a/src/virt-v

[Spice-devel] [PATCH] Disable IME to allow receiving all keys

2016-04-18 Thread Frediano Ziglio
From: Christophe Fergeau This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1297640 Acked-by: Frediano Ziglio --- src/virt-viewer-util.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/virt-viewer-util.c b/src/virt-viewer-util.c index 279f9a5..8cf52ec 100644 --- a/src/virt-v