Re: [Spice-devel] [PATCH] Avoid passing libusb functions as callbacks

2018-08-22 Thread Victor Toso
Hi, On Wed, Aug 22, 2018 at 09:03:03AM +0200, Javier Celaya wrote: > Hi, > El mar, 21-08-2018 a las 09:47 -0400, Frediano Ziglio escribió: > > > > Hi, > > On Tue, Aug 21, 2018 at 02:53:59PM +0200, Javier Celaya wrote: > > Yes, not against merging the fix. But if we can get it fixedinGlib, > > it

Re: [Spice-devel] [PATCH] Avoid passing libusb functions as callbacks

2018-08-22 Thread Javier Celaya
Hi, El mar, 21-08-2018 a las 09:47 -0400, Frediano Ziglio escribió: > > Hi, > On Tue, Aug 21, 2018 at 02:53:59PM +0200, Javier Celaya wrote: > Yes, not against merging the fix. But if we can get it fixedinGlib, > it is matter to help other projects that port codetowindows to be > fixed as well, et

Re: [Spice-devel] [PATCH] Avoid passing libusb functions as callbacks

2018-08-21 Thread Frediano Ziglio
> > Hi, > > On Tue, Aug 21, 2018 at 02:53:59PM +0200, Javier Celaya wrote: > > > Yes, not against merging the fix. But if we can get it fixed > > > inGlib, it is matter to help other projects that port code > > > towindows to be fixed as well, etc. > > > Please open a bug in Glib and add a refere

Re: [Spice-devel] [PATCH] Avoid passing libusb functions as callbacks

2018-08-21 Thread Victor Toso
Hi, On Tue, Aug 21, 2018 at 02:53:59PM +0200, Javier Celaya wrote: > > Yes, not against merging the fix. But if we can get it fixed > > inGlib, it is matter to help other projects that port code > > towindows to be fixed as well, etc. > > Please open a bug in Glib and add a reference to it in the

Re: [Spice-devel] [PATCH] Avoid passing libusb functions as callbacks

2018-08-21 Thread Javier Celaya
Hi, El mar, 21-08-2018 a las 09:29 +0200, Victor Toso escribió: > Hi, > On Tue, Aug 21, 2018 at 03:18:35AM -0400, Frediano Ziglio wrote: > > Hi,On Fri, 2018-08-17 at 15:24 +0200, Victor Toso wrote: > Hi, > On Fri, Aug 17, 2018 at 03:12:35PM +0200, jorge.olmos@flexvdi.comwrot > e: > From: Jorge Olm

Re: [Spice-devel] [PATCH] Avoid passing libusb functions as callbacks

2018-08-21 Thread Victor Toso
Hi, On Tue, Aug 21, 2018 at 03:18:35AM -0400, Frediano Ziglio wrote: > > > > Hi, > > On Fri, 2018-08-17 at 15:24 +0200, Victor Toso wrote: > > > Hi, > > > > > > On Fri, Aug 17, 2018 at 03:12:35PM +0200, jorge.ol...@flexvdi.com > > > wrote: > > > > From: Jorge Olmos > > > > > > > > When buildin

Re: [Spice-devel] [PATCH] Avoid passing libusb functions as callbacks

2018-08-21 Thread Frediano Ziglio
> > Hi, > On Fri, 2018-08-17 at 15:24 +0200, Victor Toso wrote: > > Hi, > > > > On Fri, Aug 17, 2018 at 03:12:35PM +0200, jorge.ol...@flexvdi.com > > wrote: > > > From: Jorge Olmos > > > > > > When building spice-gtk for windows: > > > - libusb uses __stdcall calling convention when compiled fo

Re: [Spice-devel] [PATCH] Avoid passing libusb functions as callbacks

2018-08-17 Thread Jorge Olmos
Hi, On Fri, 2018-08-17 at 15:24 +0200, Victor Toso wrote: > Hi, > > On Fri, Aug 17, 2018 at 03:12:35PM +0200, jorge.ol...@flexvdi.com > wrote: > > From: Jorge Olmos > > > > When building spice-gtk for windows: > > - libusb uses __stdcall calling convention when compiled for win32. > > It does >

Re: [Spice-devel] [PATCH] Avoid passing libusb functions as callbacks

2018-08-17 Thread Victor Toso
Hi, On Fri, Aug 17, 2018 at 03:12:35PM +0200, jorge.ol...@flexvdi.com wrote: > From: Jorge Olmos > > When building spice-gtk for windows: > - libusb uses __stdcall calling convention when compiled for win32. It does > not include an option to be compiled with __cdecl calling convention. > Direct

[Spice-devel] [PATCH] Avoid passing libusb functions as callbacks

2018-08-17 Thread jorge . olmos
From: Jorge Olmos When building spice-gtk for windows: - libusb uses __stdcall calling convention when compiled for win32. It does not include an option to be compiled with __cdecl calling convention. Directly calling libusb functions works fine. But it is a problem when its functions are passed