Re: [Spice-devel] [PATCH] Add casts for compatibility purposes

2012-03-14 Thread Marc-André Lureau
Hi On Tue, Feb 14, 2012 at 9:41 AM, Alon Levy wrote: > On Mon, Feb 13, 2012 at 01:53:32PM -0600, Dan McGee wrote: >> Some non-Linux platforms return a (caddr_t *) result for the return >> value of mmap(), which is very unfortunate. Add a (void *) cast to >> explicitly avoid the warning when compi

Re: [Spice-devel] [PATCH] Add casts for compatibility purposes

2012-02-14 Thread Alon Levy
On Mon, Feb 13, 2012 at 01:53:32PM -0600, Dan McGee wrote: > Some non-Linux platforms return a (caddr_t *) result for the return > value of mmap(), which is very unfortunate. Add a (void *) cast to > explicitly avoid the warning when compiling with -Werror. > > For the IO vector related stuff, sig

[Spice-devel] [PATCH] Add casts for compatibility purposes

2012-02-13 Thread Dan McGee
Some non-Linux platforms return a (caddr_t *) result for the return value of mmap(), which is very unfortunate. Add a (void *) cast to explicitly avoid the warning when compiling with -Werror. For the IO vector related stuff, signed vs. unsigned comes into play so adding a (void *) cast here is te