Re: [Spice-devel] [NSIS 1/2] Allow custom installer filename and displayed name version

2015-10-26 Thread Christophe Fergeau
Hey, On Mon, Oct 26, 2015 at 05:24:07PM +0200, Yedidyah Bar David wrote: > On Mon, Oct 26, 2015 at 4:58 PM, Christophe Fergeau > wrote: > > On Mon, Oct 26, 2015 at 12:35:28PM +0200, Yedidyah Bar David wrote: > >> Allow passing: > >> > >> DISPLAYED_VERSION (defaults to $VERSION): what's written t

Re: [Spice-devel] [NSIS 1/2] Allow custom installer filename and displayed name version

2015-10-26 Thread Yedidyah Bar David
On Mon, Oct 26, 2015 at 4:58 PM, Christophe Fergeau wrote: > On Mon, Oct 26, 2015 at 12:35:28PM +0200, Yedidyah Bar David wrote: >> Allow passing: >> >> DISPLAYED_VERSION (defaults to $VERSION): what's written to the >> registry. This is what is shown to the user e.g. in the control panel. >> >> E

Re: [Spice-devel] [NSIS 1/2] Allow custom installer filename and displayed name version

2015-10-26 Thread Christophe Fergeau
On Mon, Oct 26, 2015 at 12:35:28PM +0200, Yedidyah Bar David wrote: > Allow passing: > > DISPLAYED_VERSION (defaults to $VERSION): what's written to the > registry. This is what is shown to the user e.g. in the control panel. > > EXE_VERSION (defaults to -$VERSION): appended to installer filename

[Spice-devel] [NSIS 1/2] Allow custom installer filename and displayed name version

2015-10-26 Thread Yedidyah Bar David
Allow passing: DISPLAYED_VERSION (defaults to $VERSION): what's written to the registry. This is what is shown to the user e.g. in the control panel. EXE_VERSION (defaults to -$VERSION): appended to installer filename. Not touching VERSION, which reflects the version of the installer's source co

Re: [Spice-devel] [NSIS 1/2] Allow custom installer filename and displayed name version

2015-10-26 Thread Yedidyah Bar David
On Mon, Oct 26, 2015 at 11:53 AM, Christophe Fergeau wrote: > On Sun, Oct 25, 2015 at 05:14:06PM +0200, Yedidyah Bar David wrote: >> Allow passing: >> >> DISPLAYED_VERSION (defaults to $VERSION): what's written to the registry >> >> EXE_VERSION (defaults to -$VERSION): appended to installer filena

Re: [Spice-devel] [NSIS 1/2] Allow custom installer filename and displayed name version

2015-10-26 Thread Christophe Fergeau
On Sun, Oct 25, 2015 at 05:14:06PM +0200, Yedidyah Bar David wrote: > Allow passing: > > DISPLAYED_VERSION (defaults to $VERSION): what's written to the registry > > EXE_VERSION (defaults to -$VERSION): appended to installer filename This still does not say what do they mean, why 2 different ver

[Spice-devel] [NSIS 1/2] Allow custom installer filename and displayed name version

2015-10-25 Thread Yedidyah Bar David
Allow passing: DISPLAYED_VERSION (defaults to $VERSION): what's written to the registry EXE_VERSION (defaults to -$VERSION): appended to installer filename Change-Id: Id60a990aea8e9148c0cd47dd685f9681395ac624 Signed-off-by: Yedidyah Bar David --- win-guest-tools.nsis | 12 ++-- 1 file