Re: [Spice-devel] [3/6] [PATCH spice] Add horizontal mouse wheel support

2017-11-07 Thread Matthew J. Francis
On 07/11/2017 01:49, Christophe Fergeau wrote: One note here, when running a wayland spice-gtk/remote-viewer, the only scroll events I'm getting are GDK_SCROLL_SMOOTH events, I'm not getting any scroll event until I add GDK_SMOOTH_SCROLL_MASK to the events spice-gtk listens to (which results in

Re: [Spice-devel] [3/6] [PATCH spice] Add horizontal mouse wheel support

2017-11-06 Thread Christophe Fergeau
On Mon, Oct 30, 2017 at 10:22:40PM +0800, Matthew J. Francis wrote: > On 30/10/2017 17:28, Frediano Ziglio wrote: > > This patch changes ABI so would need a version bump and a Qemu patch. > > Did you send a patch to Qemu too? > > As mentioned in the patch overview, I haven't touched qemu yet - if

Re: [Spice-devel] [3/6] [PATCH spice] Add horizontal mouse wheel support

2017-11-06 Thread Christophe Fergeau
On Fri, Nov 03, 2017 at 02:47:17PM +0800, Matthew J. Francis wrote: > Following up to myself: > I got at least two things wrong in the above analysis. > > Firstly, in the Xspice case, we control both ends of the fake uinput > connection (written to by vdagentd, read from by the "xspice pointer" >

Re: [Spice-devel] [3/6] [PATCH spice] Add horizontal mouse wheel support

2017-11-02 Thread Matthew J. Francis
On 02/11/2017 12:53, Matthew J. Francis wrote: Based on some research into what would be required to support this through the SPICE stack, the implications for the protocol (an extra message), server (extra methods in the mouse and tablet interfaces) and spice-gtk (fairly easy plumbing) seem most

Re: [Spice-devel] [3/6] [PATCH spice] Add horizontal mouse wheel support

2017-11-01 Thread Matthew J. Francis
On 01/11/2017 01:20, Christophe de Dinechin wrote: Matthew J. Francis writes: What requirements might there be in terms of touch pads? I would expect touch pads (and some mice) to send events that have delta_x and delta_y in the same GdkEventScroll message. Some testing on macOS with a MacBoo

Re: [Spice-devel] [3/6] [PATCH spice] Add horizontal mouse wheel support

2017-10-31 Thread Christophe de Dinechin
Matthew J. Francis writes: > On 30/10/2017 17:28, Frediano Ziglio wrote: >> This patch changes ABI so would need a version bump and a Qemu patch. >> Did you send a patch to Qemu too? > > As mentioned in the patch overview, I haven't touched qemu yet - if I > can get agreement on what the API/ABI s

Re: [Spice-devel] [3/6] [PATCH spice] Add horizontal mouse wheel support

2017-10-30 Thread Matthew J. Francis
On 30/10/2017 17:28, Frediano Ziglio wrote: This patch changes ABI so would need a version bump and a Qemu patch. Did you send a patch to Qemu too? As mentioned in the patch overview, I haven't touched qemu yet - if I can get agreement on what the API/ABI should look like from the SPICE end, I

Re: [Spice-devel] [3/6] [PATCH spice] Add horizontal mouse wheel support

2017-10-30 Thread Frediano Ziglio
> > Signed-off-by: Matthew Francis > --- > README | 2 +- > configure.ac| 2 +- > server/inputs-channel.c | 15 +++ > server/spice-input.h| 8 > 4 files changed, 17 insertions(+), 10 deletions(-) > > diff --git a/README b/README > index 4

[Spice-devel] [3/6] [PATCH spice] Add horizontal mouse wheel support

2017-10-25 Thread Matthew Francis
Signed-off-by: Matthew Francis --- README | 2 +- configure.ac| 2 +- server/inputs-channel.c | 15 +++ server/spice-input.h| 8 4 files changed, 17 insertions(+), 10 deletions(-) diff --git a/README b/README index 4aaf6a7..1e6e677 100644